Repository navigation
fix(http-client-python): upgrade Python installers - #12362
Draft
Libba Lawrence (l0lawrence) wants to merge 7 commits into
Draft
Libba Lawrence (l0lawrence) wants to merge 7 commits into
Libba Lawrence (l0lawrence) wants to merge 7 commits into
Conversation
…mums Co-authored-by: Copilot App <[email protected]>
Libba Lawrence (l0lawrence)
requested review from
Chenxi Jiang (ChenxiJiang333),
catalinaperalta,
iscai-msft,
Kashif Khan (kashifkhan),
Laurent Mazuel (lmazuel),
Mark Cowlishaw (markcowl),
Yuchao Yan (msyyc),
Chenjie Shi (tadelesh),
Timothee Guerin (timotheeguerin) and
Jeff Fisher (xirzec)
as code owners
October 22, 2026 17:13
microsoft-github-policy-service
Bot
added
emitter:client:python
Libba Lawrence (l0lawrence)
changed the title
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
Co-authored-by: Copilot App <[email protected]>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Setup can fail with older host pip versions, and subsequent generator installs can bypass the upgraded uv executable.
2 open issues
What changed in this PR
This PR updates Python installer minimums for the HTTP client emitter’s setup, tests, and CI.
Changes:
- Adds pip and uv upgrades during virtual-environment setup and test-package installation.
- Raises test dependency minimums for pip, uv, and certifi.
- Adds installer upgrades to Python CI jobs and records the change in Chronus.
| File | Description |
|---|---|
packages/http-client-python/tests/requirements/docs.txt |
Sets the documentation environment’s pip minimum. |
packages/http-client-python/tests/requirements/base.txt |
Adds pip, uv, and certifi minimums. |
packages/http-client-python/tests/install_packages.py |
Upgrades tooling before installing generated test packages. |
packages/http-client-python/eng/scripts/setup/package_manager.py |
Adds tooling upgrades when preparing generator environments. |
.github/workflows/ci-python.yml |
Upgrades installers before Python setup in CI jobs. |
.chronus/changes/python-tooling-minimums-2026-10-22.md |
Documents the tooling and dependency updates. |
Review effort: Balanced
| if package_manager == "uv": | ||
| command = host_install + ["--python", venv_context.env_exe, "--upgrade", "--prerelease=disallow"] | ||
| else: | ||
| command = host_install[:-1] + ["--python", venv_context.env_exe, "install", "--upgrade"] |
|
|
||
| return MockVenvContext(venv_path) | ||
| context = MockVenvContext(venv_path) | ||
| upgrade_tooling(context, package_manager) |
| env_builder = venv.EnvBuilder(with_pip=False) | ||
| context = env_builder.ensure_directories(venv_path) | ||
| else: | ||
| env_builder = ExtendedEnvBuilder(with_pip=True, upgrade_deps=True) |
Member
Author
There was a problem hiding this comment.
this technically should upgrade deps but I dont know if it guarentees the lowest min version
Contributor
Python emitter diffBaseline No changes to generated output. Rendered diff: inline on the run summary, or the emitter-diff-html artifact. Informational check (eng/emitter-diff); does not block the PR. |
Libba Lawrence (l0lawrence)
marked this pull request as draft
October 22, 2026 17:52
Co-authored-by: Copilot App <[email protected]>
|
You can try these changes here
|
Co-authored-by: Copilot App <[email protected]>
Co-authored-by: Copilot App <[email protected]>
iscai-msft
approved these changes
Oct 23, 2026
iscai-msft
approved these changes
Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.