Repository navigation
fix(http-client-java): make YAML deserialization context-aware - #12434
Merged
Weidong Xu (weidongxu-microsoft) merged 3 commits intoOct 30, 2026
Conversation
Co-authored-by: Copilot <[email protected]> Copilot-Session: 60868175-cb81-4b72-83af-4b789c536100
Co-authored-by: Copilot <[email protected]> Copilot-Session: 60868175-cb81-4b72-83af-4b789c536100
microsoft-github-policy-service
Bot
added
the
emitter:client:java
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the context-aware YAML deserialization change.
No open issues 🎉
What changed in this PR
Makes the Java generator’s code-model YAML deserialization context-aware, preventing service-defined keys such as discriminator value responses from being mistaken for structural properties.
Changes:
- Restricts structural preprocessing to the owning model classes, leaving typed-map keys and example payloads untouched.
- Adds regression tests for special-key collisions, schema types, and alias identity.
- Adds a Java emitter bug-fix changelog entry.
| File | Description |
|---|---|
packages/http-client-java/generator/http-client-generator-core/src/test/java/com/microsoft/typespec/http/client/generator/core/extension/model/codemodel/CodeModelCustomConstructorTests.java |
Tests key collisions, payload preservation, schema types, and aliases. |
packages/http-client-java/generator/http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/extension/model/codemodel/CodeModelCustomConstructor.java |
Scopes YAML preprocessing to owning beans and handles examples separately. |
.chronus/changes/http-client-java-context-aware-yaml-reader.md |
Documents the service-defined map-key fix. |
Review effort: Balanced
Contributor
|
All changed packages have been documented.
Show changes
|
…ressions Co-authored-by: Copilot <[email protected]> Copilot-Session: 60868175-cb81-4b72-83af-4b789c536100
Weidong Xu (weidongxu-microsoft)
marked this pull request as ready for review
October 29, 2026 12:54
|
You can try these changes here
|
Contributor
Author
|
The regression combines two changes/conditions:
The emitter change exposed an existing reader defect; different TCGC output is not required to explain the regression. #12428 guarded This PR limits structural preprocessing to the owning Java beans, leaving dictionary keys untouched. |
Weidong Xu (weidongxu-microsoft)
enabled auto-merge
October 29, 2026 13:58
Xiaofei Cao (XiaofeiCao)
approved these changes
Oct 30, 2026
Weidong Xu (weidongxu-microsoft)
deleted the
fix/java-context-aware-yaml-reader
branch
October 30, 2026 01:34
Weidong Xu (weidongxu-microsoft)
added a commit
to Azure/typespec-azure
that referenced
this pull request
Oct 30, 2026
…es (#5900) ## Summary - sync Java generator to core `6ba281975` - fix YAML structural-key collisions (microsoft/typespec#12434) - preserve ARM resource ID parameters for shared-model routes (microsoft/typespec#12443) - sync regression fixtures and tests; retain version 0.48.4 for a separate publish PR ## Validation - emitter/generator build and client regeneration - all 7 generated-client resource ID parsing regressions pass - Chronus verification, formatting, and lint The earlier SDK sync run 7018297 timed out at 120 minutes; it has not been rerun for this update. --------- Copilot-Session: cd6f2e08-d6d3-42ae-affd-bc71e98086f7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Java code-model YAML deserialization context-aware: preprocess structural properties only on their owning beans, leaving typed-map keys and example payloads untouched.
Extends #12428 to address collisions such as discriminator value
responses, reported in Azure/azure-sdk-for-java#50875. Retains the existing tests and adds coverage for all special keys, other typed maps, schema types, and aliases.Adds a permanent TypeSpec regression to
discriminator-edge-cases.tspcoveringall,immediate,responses, andexceptions.Validation
mvn verify, 53 emitter tests, build, formatting, and lint passed.