Repository navigation
fix(typo): correct 'paramters' typo in compiler completion label and http-server-js doc comment - #12436
Open
RoomWithOutRoof (Jah-yee) wants to merge 1 commit into
Open
fix(typo): correct 'paramters' typo in compiler completion label and http-server-js doc comment#12436RoomWithOutRoof (Jah-yee) wants to merge 1 commit into
RoomWithOutRoof (Jah-yee) wants to merge 1 commit into
Conversation
…http-server-js doc comment
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the spelling corrections and accompanying Chronus entries.
No open issues 🎉
What changed in this PR
Corrects two spelling errors in TypeSpec: user-visible compiler completion text and an HTTP server JavaScript documentation comment. No runtime logic changes.
Changes:
- Replaces
paramterswithparametersin both locations. - Adds separate Chronus entries for the compiler fix and comment-only change.
| File | Description |
|---|---|
packages/http-server-js/src/util/differentiate.ts |
Corrects the DifferentiateModelOptions doc comment. |
packages/compiler/src/server/tspconfig/completion.ts |
Corrects custom-variable completion text. |
.chronus/changes/fix-paramters-typo-http-server-js-2026-10-29-13-55-0.md |
Records the comment correction as an internal change. |
.chronus/changes/fix-paramters-typo-compiler-2026-10-29-13-55-0.md |
Records the user-visible compiler fix. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two misspelled occurrences of
paramters(should beparameters) in the TypeSpec repository.Changes
packages/compiler/src/server/tspconfig/completion.tstspconfigvariables readCustom paramters variables. It is nowCustom parameters variables. This is user-visible text in thetspconfigYAML completion list, so the label is corrected.packages/http-server-js/src/util/differentiate.tsDifferentiateModelOptionsreadOptional paramters for model differentiation.It is nowOptional parameters for model differentiation.This is a comment-only change; no runtime behavior is affected.Verification
grep -rn "paramters" packages/returns no matches after the change (both occurrences are fixed and no other file inpackages/contains the misspelling).paramtersin the repository are insideCHANGELOG/release-note files, which are historical records and intentionally left untouched.Change entries
Two Chronus change entries are included, following
.chronus/config.yaml:.chronus/changes/fix-paramters-typo-compiler-2026-10-29-13-55-0.md—changeKind: fixfor@typespec/compiler(user-visible completion label)..chronus/changes/fix-paramters-typo-http-server-js-2026-10-29-13-55-0.md—changeKind: internalfor@typespec/http-server-js(comment-only change).