Skip to content

Update from Library.Template - #420

Merged
Andrew Arnott (AArnott) merged 17 commits into
mainfrom
dev/andarno/libtemplateUpdate
Oct 14, 2026
Merged

Andrew Arnott (AArnott) merged 17 commits into
mainfrom
dev/andarno/libtemplateUpdate

Conversation

@AArnott

Copy link
Copy Markdown
Member

Why

Keep vs-validation aligned with the latest Library.Template guidance and tooling improvements.

What changed

  • Move TUnit/Microsoft.Testing.Platform test-running guidance into the testing skill and update repository instructions accordingly.
  • Refresh shared dependency/tool versions and the .NET SDK installation helper.
  • Apply related CI pipeline, artifact publishing, and test-script updates.

Validation

  • dotnet restore and dotnet build succeeded.
  • tools/dotnet-test-cloud.ps1 -Configuration Release -IncludeNativeAOT passed (231 tests).
  • dotnet publish tools/dirs.proj -c Release succeeded after initializing Visual Studio developer tools in PowerShell.

renovate Bot and others added 16 commits October 7, 2026 07:16
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lls (593)

Machine-wide installs checked for already-installed SDKs and runtimes under the
native Program Files dotnet directory regardless of the process architecture.
In x86 PowerShell on x64 Windows, or x64 PowerShell on ARM64 Windows, that is
the wrong root, so missing components could be skipped. Select the root where
each architecture's installer actually puts them.
CFSClean2 is included by default (at least for some pipelines) but CFSClean is *not* and we're getting compliance issues filed because nuget.org is reached.
Adding CFSClean explicitly solves it.
Pass the tree-node filter as a single option argument for managed and NativeAOT test runs to avoid platform-specific argument parsing failures.

Co-authored-by: Copilot App <[email protected]>
Pass the tree-node filter as a single option argument for managed and NativeAOT test runs to avoid platform-specific argument parsing failures.

Co-authored-by: Copilot App <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Conflicts: AGENTS.md took incoming (testing docs moved to the testing skill, with repo project paths filled in); CONTRIBUTING.md kept repo NativeAOT docs plus the PublishNativeAOTTests note; Directory.Packages.props kept repo versions and took MTP 2.5.1; re-deleted test/Library.Tests/CalculatorTests.cs.

Co-authored-by: Copilot App <[email protected]>
Copilot AI balanced review requested due to automatic review settings October 14, 2026 18:19

Copilot AI commented Oct 14, 2026

Copy link
Copy Markdown

One or more custom setup steps configured for this repository failed during this Copilot code review run:

⚙ Install prerequisites

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The testing instructions omit the analyzer suite and include a listing command that fails from the repository root.

2 open findings
What changed in this PR

Aligns the repository with Library.Template updates to testing guidance, tooling, and CI.

Changes:

  • Moves testing instructions into a dedicated skill.
  • Refreshes dependencies and architecture-aware SDK detection.
  • Updates cloud-test filtering, artifact uploads, and pipeline network policies.
File Description
tools/​Install-DotNetSdk.ps1 Detects architecture-specific Windows installation paths.
tools/​dotnet-test-cloud.ps1 Excludes cloud-incompatible tests.
Directory.Packages.props Updates Microsoft.Testing.Platform.
CONTRIBUTING.md Documents NativeAOT test opt-out.
azure-pipelines/​vs-validation.yml Updates network policy.
azure-pipelines/​vs-insertion.yml Updates network policy.
azure-pipelines/​unofficial.yml Updates network policy.
azure-pipelines/​release.yml Updates network policy.
azure-pipelines/​official.yml Updates network policy.
azure-pipelines/​libtemplate-update.yml Updates network policy.
azure-pipelines/​archive-sourcecode.yml Updates network policy.
AGENTS.md Removes relocated testing guidance.
.github/​actions/​publish-artifacts/​action.yaml Updates artifact-upload action.
.config/​dotnet-tools.json Updates coverage and symbol tools.
.agents/​skills/​testing/​SKILL.md Adds dedicated testing guidance.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .agents/skills/testing/SKILL.md Outdated
Comment thread .agents/skills/testing/SKILL.md Outdated
Restore the solution-wide test command and correct the test listing invocation. Keep dotnet-symbol at the version available on the configured package feed so CI tool restore succeeds.

Co-authored-by: Copilot App <[email protected]>
Copilot AI balanced review requested due to automatic review settings October 14, 2026 18:27
@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.88%. Comparing base (4679e8a) to head (b12f6e6).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #420   +/-   ##
=======================================
  Coverage   77.88%   77.88%           
=======================================
  Files          14       14           
  Lines         859      859           
  Branches      224      224           
=======================================
  Hits          669      669           
  Misses        126      126           
  Partials       64       64           
Flag Coverage Δ
Linux 79.18% <ø> (ø)
Windows 77.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Only an optional documentation formatting correction remains; no blocking issues were identified.

0 open findings

2 resolved since last review
Previously missed (1)

In code that hasn't changed since last review

Low severity Replace literal backtick-n with an actual newline

CONTRIBUTING.md:52

Optional: replace the literal backtick-n sequence with an actual newline. Markdown does not interpret this PowerShell escape, so it disrupts the formatting between the sentences.

🧠 Review effort: Balanced

@AArnott
Andrew Arnott (AArnott) merged commit 65b15bd into main Oct 14, 2026
10 checks passed
@AArnott
Andrew Arnott (AArnott) deleted the dev/andarno/libtemplateUpdate branch October 14, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants