Repository navigation
Avoid shell args for global package manager lookup - #1876
Open
Pradeep Ramola (pradeep-ramola) wants to merge 1 commit into
Open
Pradeep Ramola (pradeep-ramola) wants to merge 1 commit into
Pradeep Ramola (pradeep-ramola) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses microsoft/vscode-eslint#2237
The Windows global npm/yarn path resolver used
spawnSync(..., args, { shell: true })for.cmdpackage manager commands. Node 24 emits DEP0190 for that combination.This updates the shared resolver to invoke
cmd.exe /d /s /c <package-manager>.cmd ...directly on Windows, so Node no longer receives ashell: truechild-process call with an args array. Non-Windows behavior remains unchanged.Validated on Windows with Node 24:
npm run compile:server npm run lint --prefix server node --trace-deprecation -e "const files=require('./server/lib/node/files'); const result=files.resolveGlobalNodePath((message)=>console.log(message)); console.log('resolved=' + result);"The resolver still returned the npm global
node_modulespath and no DEP0190 trace was emitted.