Skip to content

Avoid shell args for global package manager lookup - #1876

Open
Pradeep Ramola (pradeep-ramola) wants to merge 1 commit into
microsoft:mainfrom
pradeep-ramola:fix/GH-2237-node-path-deprecation
Open

Pradeep Ramola (pradeep-ramola) wants to merge 1 commit into
microsoft:mainfrom
pradeep-ramola:fix/GH-2237-node-path-deprecation

Conversation

@pradeep-ramola

Copy link
Copy Markdown

Addresses microsoft/vscode-eslint#2237

The Windows global npm/yarn path resolver used spawnSync(..., args, { shell: true }) for .cmd package manager commands. Node 24 emits DEP0190 for that combination.

This updates the shared resolver to invoke cmd.exe /d /s /c <package-manager>.cmd ... directly on Windows, so Node no longer receives a shell: true child-process call with an args array. Non-Windows behavior remains unchanged.

Validated on Windows with Node 24:

npm run compile:server
npm run lint --prefix server
node --trace-deprecation -e "const files=require('./server/lib/node/files'); const result=files.resolveGlobalNodePath((message)=>console.log(message)); console.log('resolved=' + result);"

The resolver still returned the npm global node_modules path and no DEP0190 trace was emitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant