Skip to content

PipPackageManager: Refactor package version availability check - #1914

Merged
Eduardo Villalpando Mello (edvilme) merged 3 commits into
mainfrom
api-2-pip-versionlookup-check
Oct 9, 2026
Merged

Eduardo Villalpando Mello (edvilme) merged 3 commits into
mainfrom
api-2-pip-versionlookup-check

Conversation

@edvilme

@edvilme Eduardo Villalpando Mello (edvilme) commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Added utility method _getPackageAvailableVersionsCommand to return the appropriate PackageManagerCommand to use when calling the version lookup functionality.
This abstracts the selection logic and makes feature discoverability easier.

This attempts to introduce no behavioral changes.

This comment was marked as resolved.

Co-authored-by: Copilot Autofix powered by AI <[email protected]>
@edvilme

Copy link
Copy Markdown
Contributor Author

This is pre-work for #1874

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The refactor preserves existing lookup behavior and remains adequately covered by tests.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

@heejaechang

Heejae Chang (heejaechang) commented Oct 8, 2026 •

Copy link
Copy Markdown

🔒 Automated review in progress — Heejae Chang (@heejaechang) is auto-reviewing this PR.

@edvilme Eduardo Villalpando Mello (edvilme) changed the title PipPackageManager: Refactor package availability check PipPackageManager: Refactor package version availability check Oct 8, 2026
Comment thread src/managers/builtin/pipPackageManager.ts
@heejaechang Heejae Chang (heejaechang) added the review-auto:changes-requested Automated review: posted blocking findings to address. label Oct 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@heejaechang Heejae Chang (heejaechang) added review-auto:approved Automated review: no blocking findings (approval posted). and removed review-auto:changes-requested Automated review: posted blocking findings to address. labels Oct 9, 2026
@edvilme
Eduardo Villalpando Mello (edvilme) merged commit 720981a into main Oct 9, 2026
112 checks passed
@edvilme
Eduardo Villalpando Mello (edvilme) deleted the api-2-pip-versionlookup-check branch October 9, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Code quality issues review-auto:approved Automated review: no blocking findings (approval posted). skip tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants