Skip to content

PyREPL: Update Regex in all places #26212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eduardo Villalpando Mello (edvilme) merged 2 commits into from
Oct 7, 2026
Merged

PyREPL: Update Regex in all places #26212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0916b0
PyREPL: Update Regex
edvilme Oct 7, 2026
90d5d16
Revert testing changes
edvilme Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions python_files/pythonrc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@ def _initialize():
if sys.version_info >= (3, 13):
import re

import _pyrepl.simple_interact
import _pyrepl.utils

_pyrepl.utils.ANSI_ESCAPE_SEQUENCE = re.compile(
r"\x1b(?:\[[ -@]*[A-~]|\][^\x1b\x07]*(?:\x07|\x1b\\))"
)
_ansi_escape_sequence = re.compile(r"\x1b(?:\[[ -@]*[A-~]|\][^\x1b\x07]*(?:\x07|\x1b\\))")
_pyrepl.utils.ANSI_ESCAPE_SEQUENCE = _ansi_escape_sequence

# Import again to ensure the module is loaded after patching the ANSI_ESCAPE_SEQUENCE
import _pyrepl.simple_interact

# Patch _pyrepl.simple_interact.multiline_input to ensure prompts are strings
_original_multiline_input = _pyrepl.simple_interact.multiline_input
Expand Down
12 changes: 12 additions & 0 deletions python_files/tests/test_shell_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,18 @@ def test_replacement_regex_preserves_csi_handling():
)


def test_replacement_regex_is_imported_by_pyrepl_modules():
if sys.version_info < (3, 15):
return

pyrepl_reader = importlib.import_module("_pyrepl.reader")
pyrepl_render = importlib.import_module("_pyrepl.render")

assert pyrepl_reader.ANSI_ESCAPE_SEQUENCE.sub("", "\x1b]633;A\x07>>> ") == ">>> "
assert pyrepl_render.ANSI_ESCAPE_SEQUENCE.sub("", "\x1b]633;A\x07>>> ") == ">>> "
assert pyrepl_render.RenderLine.from_rendered_text("\x1b]633;A\x07>>> ").width == 4


def test_pyrepl_multiline_input_converts_prompts_to_strings(monkeypatch):
if sys.version_info < (3, 13):
return
Expand Down
Loading