Skip to content

fix(deps): update renderer nanoid to 3.3.19 - #273

Merged
Angnuo (angnuoli) merged 1 commit into
mainfrom
codex/nanoid-security-update
Oct 27, 2026
Merged

Angnuo (angnuoli) merged 1 commit into
mainfrom
codex/nanoid-security-update

Conversation

@angnuoli

@angnuoli Angnuo (angnuoli) commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Replace closed Dependabot PR build(deps): bump nanoid from 3.3.12 to 3.3.18 in /desktop/renderer #201 with a focused update based on current main (d9236f9).
  • Update renderer's transitive nanoid dependency from 3.3.12 to 3.3.19, rather than the old PR's 3.3.18 target. Official 3.3.19 notes: fixes application crashes caused by oversized user IDs.
  • Change only nanoid's version and SHA512 integrity in desktop/renderer/package-lock.json. Preserve all unrelated lockfile metadata, including jschardet's resolved entry.

Validation

  • Current configured npm mirror provides nanoid 3.3.19. Downloaded its tarball without executing scripts and verified SHA512 against registry metadata.
  • Renderer npm ci: passed (392 packages). npm's existing script allowlist warned about esbuild/vue-demi; no script policy was changed.
  • Nanoid smoke checks: installed version 3.3.19, default ID generation, custom alphabet generation, oversized-ID rejection, and PostCSS resolving the updated nanoid all passed.
  • Renderer tests: 54 files passed; 797 tests passed, 2 skipped.
  • Renderer lint: 0 errors, 106 existing warnings.
  • Desktop TypeScript and renderer production build: passed (Vite 6.4.4), with existing bundle/annotation warnings.
  • Prettier on the changed lockfile and git diff --check: passed.
  • Structural lockfile comparison confirms only the intended nanoid version/integrity fields changed; desktop manifest/lockfile and renderer manifest are unchanged.

Existing baseline and CI limitations

  • Desktop npm ci still fails on main's existing jschardet lock mismatch (locked 3.1.4 versus the formatter's latest dependency resolving to 4.0.0). This PR does not modify desktop dependencies or fix that separate issue, and does not claim a successful whole-project clean install.
  • For local validation only, desktop prerequisites were installed using --ignore-scripts --no-save --package-lock=false. The same-version (33.4.11), SHA256-matching Electron runtime was reused from the existing local installation. No npm security policy was weakened.
  • GitHub PR Build remains queued on the self-hosted Windows runner; CLA passed. Remote CI is not being reported as passed. Current main rules have no required CI checks; merge will use the normal manual squash path without an administrator override or auto-merge.

Reference

@angnuoli
Angnuo (angnuoli) marked this pull request as ready for review October 27, 2026 08:33
@angnuoli
Angnuo (angnuoli) merged commit eabeeef into main Oct 27, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant