Repository navigation
fix(deps): restore jschardet resolution for npm ci - #275
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolvedtarball URL for the existing[email protected]entry indesktop/package-lock.json.Root cause
@microsoft/[email protected]requestsjschardetusing thelatesttag. The desktop lock entry had a version and integrity but no tarball resolution. With npm 11.19.1, the tag edge was re-resolved to 4.0.0, causingnpm cito reject the locked 3.1.4 version. Restoring the tarball resolution lets npm retain the existing locked dependency, as the renderer lock already does.Validation
[email protected] does not satisfy [email protected]error from current main.npm cipassed with a fresh project cache, including the rootpostinstallthat installs renderer dependencies. The desktop lock remained byte-for-byte unchanged during installation.[email protected].git diff --checkpassed.npm cipassed: 392 packages installed.Existing baseline failures / limits
desktop/src/chat-attachments.ts:105(no-control-regex) anddesktop/src/openclaw-upgrade-recovery.ts:236(@typescript-eslint/no-unused-vars, unusedreadJsonObject). These unrelated source errors are not changed by this lockfile repair.Environment: Node 24.22.1 / npm 11.19.1 on Windows. The existing npm
allowScriptspolicy still warns and skips unapproved dependency lifecycle scripts (including Electron); it was not weakened. Successful dependency installation does not claim that Windows installer packaging or Electron runtime installation has been verified.