Fixing clicking outside of a viewport issue

[aik099]

Using the moveto WebDriver command the Firefox will trigger an \WebDriver\Exception\MoveTargetOutOfBounds exception when the element is outside of the viewport:

Move target (194, 1001) is out of bounds of viewport dimensions (1550, 970)

The moveto command is used in these driver methods:

• clickOnElement
  • click (does clickOnElement internally)
  • check (does clickOnElement internally)
  • uncheck (does clickOnElement internally)
  • setValue (checkboxes only; does clickOnElement internally)
• mouseOver
  • rightClick (does mouseOver internally)
  • doubleClick (does mouseOver internally)

.

The test suite isn't testing mouse-related operations (listed above) outside of the viewport.

P.S.

• The Chrome implementation of the moveto automatically adjusts the viewport.
• Fixing idea taken from the https://github.com/minkphp/webdriver-classic-driver .

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.91%. Comparing base (2654689) to head (65652da).

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #389      +/-   ##
============================================
+ Coverage     85.82%   85.91%   +0.08%     
- Complexity      184      185       +1     
============================================
  Files             1        1              
  Lines           501      504       +3     
============================================
+ Hits            430      433       +3     
  Misses           71       71              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[stof]

shouldn't we use nearest as well in the block direction ?

[aik099]

I don't use the scrollIntoView method myself. I've only copied the whole line from the PHP WebDriver (see https://github.com/php-webdriver/php-webdriver/blob/11923b4ba312fc9d137266ae67438be65d4d500f/lib/Remote/RemoteWebElement.php#L249 ). I trust that they know what's right here.

[aik099]

@stof, my point here is still valid. I think this driver should scroll to an element exactly the same as the underlying facebook web driver does for webdriver-classic-driver driver.

[aik099]

Not merging yet, because I think we need to add a missing test in driver-testsuite.