Repository navigation
Improve CI coverage - #416
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #416 +/- ##
============================================
+ Coverage 85.42% 85.82% +0.39%
Complexity 184 184
============================================
Files 1 1
Lines 501 501
============================================
+ Hits 428 430 +2
+ Misses 73 71 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
aik099
force-pushed
the
ci-browser-matrix
branch
from
October 10, 2026 18:03
c2de089 to
6cd6b85
Compare
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
aik099
force-pushed
the
ci-browser-matrix
branch
from
October 10, 2026 18:16
d326b26 to
87458ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI tests only Firefox, so Chrome-specific problems go unnoticed.
Changes:
browserto the matrix and test Chrome on Selenium 2.53.1 and 33image tag (last Selenium 3 image) instead of3.141.59EventsTest::testKeyboardEventson Chrome with Selenium 2codecov/test-results-actionwithcodecov/codecov-action@v5(report_type: test_results)Coverage is collected only where the driver has code that runs differently:
setCookie/getCookieusesurlencode/urldecodebefore PHP 7.4The driver has no browser checks, so Chrome jobs don't collect coverage.
PHP versions are still tested on Firefox + Selenium 2.53.1, the same way as in webdriver-classic-driver (see minkphp/webdriver-classic-driver#40).
Edge and Chromium (tested in webdriver-classic-driver CI) aren't added: their Docker images exist only for Selenium 4, which this driver doesn't support. Testing them wouldn't add much anyway: both are Chromium-based like Chrome, and the driver has no code specific to them.
The keyboard events test fails on Chrome 53 (in Selenium 2.53.1 image), because it ignores
keyCode/charCode/whichpassed tonew KeyboardEvent()(used by Syn to trigger the event): the event gets key code 0. Newer Chrome (e.g. 94 in Selenium 3 image) doesn't have this problem. webdriver-classic-driver skips this test on that combination too.Supersedes #409.
🤖 Generated with Claude Code