Repository navigation
Keep the debug stream off the log server by default - #31
Open
thomas-samoht wants to merge 1 commit into
Open
thomas-samoht wants to merge 1 commit into
thomas-samoht wants to merge 1 commit into
Conversation
thomas-samoht
marked this pull request as ready for review
October 20, 2026 14:18
| if unknown: | ||
| raise ValueError(f"unknown {setting} {unknown}, choose from {list(choices)}") | ||
|
|
||
| return list(dict.fromkeys(names)) |
Member
There was a problem hiding this comment.
Just checking, names is already a list, can't that be returned?
Contributor
Author
There was a problem hiding this comment.
No, you can't return names. list(dict.fromkeys(names)) removes duplicates and keeps the original order.
But we ccould also treat duplicates as a config mistake, then _selected or the config class could raise a error, the same way it does for unknown names. Then it could return names unchanged.
if you have somethign like console_streams=["app", "app"] then that would without dedupping result in every app record printed twice
thomas-samoht
force-pushed
the
fix/debug-stream-syslog-opt-out
branch
from
October 21, 2026 08:43
127000c to
bb89e46
Compare
thomas-samoht
force-pushed
the
fix/debug-stream-syslog-opt-out
branch
from
October 21, 2026 09:04
bb89e46 to
b5f3470
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.