Repository navigation
fix: unify calendar validation and real-observation recovery - #113
Merged
Merged
Conversation
added 12 commits
October 17, 2026 15:58
Keep read-only reports, removal of synthetic filling, and exact Databento recovery in one maintainer-directed workflow. Preserve each reviewed source commit and its regression evidence. Include the source guide batching policy without creating a policy-only PR.
stefan-jansen
marked this pull request as ready for review
October 18, 2026 00:27
added 2 commits
October 17, 2026 21:13
Consolidate prepared validation issue108 into the existing calendar workflow. Reuse bounded schedule reports instead of advancing minute data by one day. Preserve explicit disabled-calendar row mode, real observations and missing-session handling. Assert the history-error stage rather than platform-specific OS wording.
The existing 365-civil-day fixture expects January1 as its next observation. Persist its actual24/7 declaration rather than letting the NYSE default select January2. Retain its original exact range assertions and the independent exchange-holiday regressions.
Databento normalizes whitespace and comma-separated strings, including strings inside a symbol list. Reject disguised ALL_SYMBOLS and comma expansion before acquisition so one missing-series report cannot trigger a universe or multi-instrument download. Three public workflow regressions fail before the guard and preserve the literal-universe control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #108. Closes #109. Part of #110, which remains open for the accepted Coin Metrics dataset-specific work.
Outcome
Contract and compatibility
Explicit calendar selection overrides declared feed/stored metadata, then NYSE applies. Explicit calendar=None disables schedule-derived handling; 24/7 remains a real schedule. Validation retains numerical checks and per-check opt-outs. Incremental row mode overlaps the latest real observation instead of inventing a next timestamp.
Explicit fill_gaps=True and synthetic SessionCompleter modes now raise before fetching or writing. Use check_gaps for inspection and explicitly invoke supported source recovery for downloads. Optional session-grid expansion exposes null placeholders only. Recovery success means processing succeeded, not that every expected observation was recoverable; inspect remaining_gaps. No-trade responses may legitimately leave absences.
One coherent maintainer-directed PR preserves the commits from owned drafts #114/#115 and the prepared validation branch. It includes implementation, regressions, maintained documentation and the source AGENTS.md batching rule. No contributor-owned work was rewritten. Data 0.2.1 remains immutable; no release or documentation deployment is performed.
Reproduction and review
Actual public APIs use real SyntheticProvider input, authoritative calendars and Flat/Hive storage. Only external SDK requests are substituted; no paid/live vendor requests or client data are used.
The owning agent reviewed declaration propagation, timestamp precision, calendar/grid boundaries, identity preservation, stale/partial/no-trade responses, error reporting after publication, request expansion and compatibility. AI assisted code, tests and documentation. No independent human review is claimed; Copilot's quota notice is not a review.
Current qualification
Reviewed head: ca35907.
107 focused report/source regressions pass in 17.65s. The exact-head full suite passes 4199 tests with 292 default-marker deselections in 359.36s and 86.50% coverage. The separate ResourceWarning-error lane passes the same 4199 tests in 351.76s. Ruff check/format (100 columns), ty, normal/all-file hooks, actionlint and strict documentation pass. Both isolated distributions pass dependency, import, CLI and README checks; separately installed wheel and sdist public report, no-op recovery, incremental planner and calendar-validator workflows pass.
Candidate 0.2.2.dev32+gca3590707: wheel SHA256 3d0cc0da2778c012ed5a5d82ca3d2c772c57c7764b1280e07a4e5a2167cf4455; sdist SHA256 4493522da3142ee0a305793dbfb220254890d19d413c5df2151e378fead0af7d. These are verification artifacts, not a published release.
At the final refresh, all 27 hosted checks are complete: 26 successes and only the configured Python 3.15 dependency-wait skip. Its exception validator passes. Supported Python 3.12-3.14 qualification passes on Linux, macOS and Windows, including the corrected Windows regression. CI run39086478121, ecosystem run39086478516, security run39086478023 and documentation run39086478155 all pass. The PR is clean and mergeable at the reviewed head; no previous-head or skipped supported-platform checks substitute for qualification.
Coin Metrics support is not claimed. The remaining required dataset choice is market candles, asset metrics/reference rates, or both; the generic report and Databento recovery do not depend on that choice.