Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CallToolResult.fromJsonreplaces missing or nullcontentwith an empty list. Applications then cannot distinguish these responses from a validcontent: []result.This adds
validateCallToolResultContent(true)to the synchronous and asynchronous client builders. When enabled,callToolchecks the raw result before converting it toCallToolResult, rejecting missing, null, or non-array content withIllegalArgumentException. An explicit empty array remains valid.The option follows the existing
McpClientFeatures.Sync/Asyncwiring. Validation accepts bothListandObject[]representations of JSON arrays, including Jackson'sUSE_JAVA_ARRAY_FOR_JSON_ARRAYsetting.The option defaults to false, preserving the compatibility behavior introduced in #928. It is independent of tool output-schema validation and does not enable strict validation of other MCP messages. Validation failures do not retry the tool call or undo server-side effects.
Validation on Java 17, with both Jackson 2 and Jackson 3:
This is a proposed public API. Please confirm the scope and naming in the related enhancement issue before requesting review.
AI-assisted implementation, submitted for human review.
Fixes #1148