Skip to content

Pass Biome with Claude Code's local files present - #199

Open
kixelated wants to merge 2 commits into
mainfrom
quest/m0/biome-local
Open

kixelated wants to merge 2 commits into
mainfrom
quest/m0/biome-local

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Completes the quest/m0/biome-local.md quest: just check now passes on a checkout that has Claude Code's per-user files, and Biome no longer warns about files it can't handle.

  • Gitignore .claude/settings.local.json and .claude/launch.json. When they're untracked, Biome formats them and fails. Biome reads the repo's .gitignore but not a global core.excludesFile, so a personal global ignore doesn't help.
  • Add !**/*.md to Biome's files.includes. Biome has no Markdown handler, so every tracked SKILL.md printed a files/missingHandler warning.
  • Delete the quest and its link in quest/m0/README.md.

Decision for review

The quest's Plan only named settings.local.json. I also ignored .claude/launch.json, the Claude desktop app's preview config. It has the same problem, and the maintainer's checkout has an untracked copy containing machine-specific paths (cwd, ports). If you'd rather share a launch config across contributors, drop that line and commit a .claude/launch.json that passes Biome.

Verification

Before the fix, with both files present in the worktree, bunx biome check reported 2 format errors (launch.json, settings.local.json) and 10 files/missingHandler warnings. After the fix, with the same files still present, quest check, just fix, and just check all pass with no warnings.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

kixelated and others added 2 commits October 23, 2026 23:17
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Gitignore the per-user .claude/settings.local.json and .claude/launch.json,
which Biome otherwise formats and fails on, and exclude Markdown from Biome,
which has no handler for it and warned on every SKILL.md.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@kixelated
kixelated marked this pull request as ready for review October 24, 2026 06:23
@kixelated

Copy link
Copy Markdown
Collaborator Author

Outcome: CI passes (check, toolchain) and the PR is ready for review. One open decision: keep .claude/launch.json gitignored (recommended, it holds machine-specific paths) or drop that line and commit a shared launch config. Suggested follow-up: none needed for this quest.

(Written by Claude Opus 5.5)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T06:24:47.718533Z fd72e9d Draft marked ready
🔒 Security Review ✅ Completed 2026-10-24T06:25:40.444189Z fd72e9d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b768f0e6-a7b0-4389-af91-62feae64f9f5
Commits

Reviewing files that changed from the base of the PR and between 76b0278 and fd72e9d.

Files selected for processing: 4
  • .gitignore
  • biome.json
  • quest/m0/README.md
  • quest/m0/biome-local.md
Files with no reviewable changes: 2
  • quest/m0/biome-local.md
  • quest/m0/README.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The changes add .claude/settings.local.json and .claude/launch.json to .gitignore, and exclude Markdown files from Biome’s files.includes patterns. They also remove the related m0 checklist item and planning document.

Priority: Low

Merge Risk: Minimal · up to fd72e

The configuration updates address the reported local-file Biome issues, with no merge-blocking risk identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "Pass Biome with Claude Code's local files present" matches the main change: the PR gitignores Claude Code per-user files and changes Biome config so that just check passes with those files …
Description check Passed The description states that the PR completes the biome-local quest so that just check passes with Claude Code's per-user files present. It lists the .gitignore additions for .claude/settings.local.jso…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Pass Biome with Claude Code's local files present" matches the main change: the PR gitignores Claude Code per-user files and changes Biome config so that just check passes with those files present. It is specific and conveys the primary intent.

Full details: Description check

Explanation

The description states that the PR completes the biome-local quest so that just check passes with Claude Code's per-user files present. It lists the .gitignore additions for .claude/settings.local.json and .claude/launch.json, the Biome files.includes change adding !**/*.md, and the deletion of the quest and its README link. It also explains the launch.json decision and the verification steps. This matches the changeset.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant