Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
The worklet plugin already emits each worklet and worker to assets/<name>.js,
so each site calls assets("/assets/") before any player starts. Bumps moq to
serve those files from the dev server too, which adds the @moq/ui workspace.
Drops the unused vite-plugin-static-copy.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Outcome: CI passes; marked ready for review. Open decisions for the maintainer:
Not verified: a real publish through (Written by Claude Opus 5.5) |
Completes
quest/m0/dogfood-assets.md.Summary
watch,publish,boy,voice-democomponents), moq.pub, and moq.watch callassets("/assets/")from the package root before any element starts, so the audio worklets and the capture worker load from the site instead ofblob:.worklet()plugin already emits each file toassets/<name>.jsin every build.vite-plugin-static-copyis dropped.index.html), so audio broke undervite/astro dev. Fixed upstream in moq-dev/moq#6626 and themoqsubmodule is bumped to it. The bump picks up the new@moq/uipackage, added toworkspaces./assets/, not the/moq/the quest and moq's docs suggest: moq.dev routes/moq*to the Worker for the Go vanity imports, and/assets/is where the plugin already puts the files.Before merging
The
moqsubmodule points at the head of moq-dev/moq#6626, which is not on moqmainyet. Once it merges, re-pin the submodule to moqmain(the squash commit) so the pin doesn't dangle when the branch is deleted.Verification
just check,just fix,quest check,bun testpass.astro buildand bothvite builds emitassets/{render-worklet,capture-worklet,capture-worker}.js.vite sites/watch --mode staging,/demo/bbb.hang):AudioWorklet.addModulereceiveshttp://localhost:5273/assets/render-worklet.js, arendernode is created, and the AudioContext runs.wrangler dev: same, from/assets/render-worklet.js; the hashed blob chunk is never fetched.astro devserves/assets/render-worklet.jsas JavaScript on/watch.wrangler dev:/assets/capture-worklet.jsloads into an AudioWorklet and/assets/capture-worker.jsstarts as a module worker and posts itsreadyreport.Not verified: an actual publish. The preview browser blocks the mic and camera, so the capture worklet was not exercised through
<moq-publish>, and the capture worker path (Firefox, Safari) was not exercised in those browsers.Follow-ups
doc/lib/js/{watch,publish}.mduse/moq/in theassets()example; fine for most sites, but worth noting the plugin'sassets/default if moq.dev is cited as the reference.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code