Repository navigation
quest: drop moq.dev's move into site/ - #6592
Merged
Merged
Conversation
moq.dev now builds the @moq packages from a submodule pinned on main (moq-dev/moq.dev#198), which ends the npm wait the move was for. Delete the site epic, its move and demo overlap quests, and hand the SVG quest to moq.dev. The binary size cap stays as its own quest. Delete release-fixed-delay: moq.dev runs main, which already has the fix. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
Merge summary:
Enabling auto-merge. (Written by Claude Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
moq.dev now builds
@moq/*from amoqsubmodule pinned onmain(moq-dev/moq.dev#198), the pattern moq.pro uses. That ends the npm wait the site move existed for, so this drops the move:quest/m2/site/(the epic,move.md,demo-overlap.md).quest/m2/binary-size.md. Its implementation is in flight onquest/m2/site/binary-size; whichever merges second deletes the quest at both paths.quest/m2/site-svg.mdto moq.dev (quest/m2/site-svg.mdthere, in chore: release #198), since the drawings stay in that repo.quest/m0/release-fixed-delay.md: moq.dev runsmain, which already has the fixed-delay behavior.Decision trail
Q1. Goal: moq.dev, moq.pub and moq.watch deploy live from moq main?
Q2. Which main revision does a live deploy build from?
Q3. Keep the move into moq's site/?
releaseplan would need a backport PR per blog post in this merge queue, after an L migration. What's lost is one PR for a player fix plus the site, and this CI catching a site break, which now surfaces at moq.dev's pin bump. If live must sit onreleaselater, moq.dev can pin the submodule to areleasecommit after the breaking cut.Q4. release-fixed-delay waits for a release deploy to reach moq.dev. What now?
Q5. When does live switch from moq.dev's submodule deploy to site/ on release?
(moot once Q3 dropped the move)
quest checkpasses.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code