Skip to content

quest: drop moq.dev's move into site/ - #6592

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/site-live-switch
Oct 23, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/site-live-switch

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

moq.dev now builds @moq/* from a moq submodule pinned on main (moq-dev/moq.dev#198), the pattern moq.pro uses. That ends the npm wait the site move existed for, so this drops the move:

  • Delete quest/m2/site/ (the epic, move.md, demo-overlap.md).
  • Keep the 500 KB binary cap, which is repository-wide, as quest/m2/binary-size.md. Its implementation is in flight on quest/m2/site/binary-size; whichever merges second deletes the quest at both paths.
  • Move quest/m2/site-svg.md to moq.dev (quest/m2/site-svg.md there, in chore: release #198), since the drawings stay in that repo.
  • Delete quest/m0/release-fixed-delay.md: moq.dev runs main, which already has the fixed-delay behavior.

Decision trail

Q1. Goal: moq.dev, moq.pub and moq.watch deploy live from moq main?

  • Yes
  • Main, but lag-pinned
  • ✅ Other: "release is still the prod site", then clarified: "moq.dev for now can use a submodule to main and we manually deploy. I think the long-term plan is to merge into the mono-repo and use the release branch?"

Q2. Which main revision does a live deploy build from?

  • Deployed commit
  • moq.pro's relay pin
  • ✅ Other: "release" (long term; superseded by Q5)

Q3. Keep the move into moq's site/?

  • Keep the move
  • Drop the move
  • ✅ Other: "it's your choice if we ever merge moq.dev into the monorepo. IDK it seems less useful now with the submodule". Agent's choice: drop it. The submodule delivers the move's main benefit, while the move's live-from-release plan would need a backport PR per blog post in this merge queue, after an L migration. What's lost is one PR for a player fix plus the site, and this CI catching a site break, which now surfaces at moq.dev's pin bump. If live must sit on release later, moq.dev can pin the submodule to a release commit after the breaking cut.

Q4. release-fixed-delay waits for a release deploy to reach moq.dev. What now?

  • Retarget to main
  • ✅ Delete now
  • Leave as is

Q5. When does live switch from moq.dev's submodule deploy to site/ on release?

  • ✅ At the breaking cut
  • Backport the move

(moot once Q3 dropped the move)

quest check passes.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

moq.dev now builds the @moq packages from a submodule pinned on main
(moq-dev/moq.dev#198), which ends the npm wait the move was for. Delete
the site epic, its move and demo overlap quests, and hand the SVG quest to
moq.dev. The binary size cap stays as its own quest. Delete
release-fixed-delay: moq.dev runs main, which already has the fix.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T22:55:01.836401Z 4f7f7a1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

  • Codex reviewed 4f7f7a1 with no findings. CodeQL passes; Check runs in the merge queue.
  • Branch is current with main (no conflicts). quest check passes (593 documents).
  • Grepped every deleted path (quest/m2/site/, quest/m2/site-svg.md, quest/m0/release-fixed-delay.md) on main and the PR head: no references remain outside the deleted files.
  • No new decisions. The binary-size implementation, moq-dev/moq#6591, still deletes quest/m2/site/binary-size.md; since this merges first, that PR should resolve the rename/delete conflict by deleting quest/m2/binary-size.md and its line in quest/m2/README.md.

Enabling auto-merge.

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit fe9bf01 into main Oct 23, 2026
9 checks passed
@kixelated
kixelated deleted the quest-plan/site-live-switch branch October 23, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant