Repository navigation
Conversation
…t actual changes to the revision
Xzzz
reviewed
Oct 30, 2026
Xzzz
requested changes
Oct 30, 2026
Xzzz
left a comment
Xzzz
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Dave, the approach looks good to me.
I checked the callers of update(): none uses its result when nothing is pending (Feed.pm:393 only calls it after adding or removing members), and both update() start with transactions => [], so the early return is safe. .set with an empty list is kept, as the new test shows.
Only the comment above: with more than 10 subscribers, the new check can skip a needed subscribers.set. Happy to approve once that's handled.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.