Repository navigation
Conversation
…lidation Firefox parses all of its metrics.yaml/pings.yaml files at the start of every build, and validating them against the JSON schema accounts for most of that time (5.2s -> 2.8s in CI, 2.5s -> 0.7s locally when skipped). Firefox already validates these files in a separate lint job (bug 2076535), so builds don't need to do it again. The new `skip_schema_validation` parser option skips the jsonschema validation step in `_load_file`, including the check that `$schema` is a known schema; the Python-level checks still run. It is only safe when the input has been validated elsewhere, since invalid input may raise exceptions rather than produce errors. The default is unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox parses all of its metrics.yaml/pings.yaml files at the start of every build, and validating them against the JSON schema accounts for most of that time (5.2s -> 2.8s in CI, 2.5s -> 0.7s locally when skipped). Firefox already validates these files in a separate lint job (bug 2076535), so builds don't need to do it again.
The new
skip_schema_validationparser option skips the jsonschema validation step in_load_file, including the check that$schemais a known schema; the Python-level checks still run. It is only safe when the input has been validated elsewhere, since invalid input may raise exceptions rather than produce errors. The default is unchanged.Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsCHANGELOG.mdor an explanation of why it does not need one