Repository navigation
Ship the SOAP encoding schema instead of fetching it - #1501
Open
DylanMerigaud wants to merge 1 commit into
Open
DylanMerigaud wants to merge 1 commit into
DylanMerigaud wants to merge 1 commit into
Conversation
zeep loads http://schemas.xmlsoap.org/soap/encoding/ whenever a WSDL uses SOAP-ENC types, including through the automatic import of that namespace. When the server is unreachable or answers 404 the WSDL fails to load, and with forbid_external enabled the load is refused. Ship a copy of the schema (the file already used by the tests, with its W3C license notice unchanged) and load it from the package for the http and https URLs instead of going through the transport. When the file is missing, for example in an application packaged without zeep's package data, the schema is loaded through the transport as before. Fixes: mvantellingen#1417 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1417: zeep ships the W3C-licensed SOAP encoding schema and reads it locally, so a 404 or
forbid_externalcan't block it. Apps packaged without zeep's package data fetch it as before. The four new tests fail on main and pass here. I left CHANGES to you.This change was prepared with AI assistance (Claude).