Repository navigation
ndncert: fix v0.3 session cryptography and add CA server - #245
Merged
Merged
Conversation
Initialize ECDH and IV state for every NEW request rather than once per Client. Cover sequential reuse, failed NEW attempts, and CA signature validation with distinct CA and requester keys.
Start IV counters at zero, encode them in big-endian order, and advance after encryption using integer block counts. Reject empty plaintext, oversized GCM messages, and exhausted counters without wrapping. Add reference-encryption, block arithmetic, and send-exhaustion regression tests.
Reject malformed cipher messages, changing or colliding IV prefixes, replayed or overlapping block ranges, and receive-counter wraparound. Update peer state only after authentication and validation, and decrypt into a private buffer without modifying the packet. Cover authenticated receive-state transitions and a two-round client CHALLENGE exchange against an independent AES-GCM peer, including replay rejection.
Share certificate-based signature verification between Data and Interest packets so the NDNCERT CA can authenticate signed requests.
Serve INFO, PROBE, NEW, and CHALLENGE requests with email and DNS-01 verification, certificate naming and validity policies, bounded challenge workers, and expiring request state. Use the session crypto helpers from #236 for both directions and return error 3 for invalid encrypted requests. Keep max-suffix-length in local policy and PROBE responses instead of extending the CA profile format. Test NEW key agreement, issuance, authorization, malformed requests, replay rejection, concurrency, expiration, and challenge attempt limits.
Add ndnd sec certca with email delivery configuration, optional object persistence, sample configuration, and startup instructions. Include system CA roots in the container for outgoing SMTP TLS connections. Fixes #237
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #239 and #240 to
dv2.Fix NDNCERT v0.3 session cryptography and add a Go certificate authority server.
ndnd sec certca, sample configuration, startup documentation, and container CA roots for SMTP TLS.--data-dir. Active requests remain in memory.Peers using the previous IV format require coordinated updates. Low-level callers must pass the session counter to
AeadDecryptand handle errors fromAeadMessage.FromTLV.