Skip to content

An attribute selector inside :where(), or a :is() of several, never matches: .test:where([data-test="abc"]) styles nothing #541

Open

Description

@YevheniiKotyrlo

Before submitting a new issue

  • I tested using the latest version of the library, as the bug might be already fixed.
  • I tested using a supported version of react native.
  • I checked for possible duplicate issues, with possible answers.

Bug summary

An attribute selector inside :where(), or inside an :is() of more than one selector, never matches: .test:where([data-test="abc"]) styles nothing on dataSet={{ test: "abc" }}, and so does .test:is([data-test="abc"], [data-other="xyz"]). A browser matches both. A single-selector :is([data-test="abc"]) works, because lightningcss flattens it into the rule's own attribute list before the compiler sees it.

The first and third cases fail; the second, a correct non-match, and the fourth pass.

parseIsWhereComponents turns each :is() or :where() branch into a container query, so the attribute test lands on a container query, which src/native/conditions/container-query.ts checks against a container's props rather than the element's own.

Library version

main at 2421ea7 (0.0.0-nightly.2421ea7)

Environment info

System:
  OS: Windows 11 10.0.26300
  CPU: "(32) x64 AMD Ryzen 9 9950X3D 16-Core Processor          "
  Memory: 155.26 GB / 255.67 GB
Binaries:
  Node:
    version: 26.12.1
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 4.9.2
    path: C:\Users\<user>\AppData\Roaming\npm\yarn.CMD
  npm:
    version: 12.2.1
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK:
    API Levels:
      - "33"
      - "35"
      - "35"
      - "35"
      - "36"
      - "37"
    Build Tools:
      - 35.0.0
      - 36.0.0
      - 36.1.0
      - 37.0.0
    System Images:
      - android-26 | Google APIs Intel x86_64 Atom
      - android-28 | Google APIs Intel x86_64 Atom
      - android-29 | Google APIs Intel x86_64 Atom
      - android-30 | Google APIs Intel x86_64 Atom
      - android-31 | Google APIs Intel x86_64 Atom
      - android-32 | Google APIs Intel x86_64 Atom
      - android-33 | Google APIs Intel x86_64 Atom
      - android-34 | Google APIs Intel x86_64 Atom
      - android-35 | Google APIs Intel x86_64 Atom
      - android-36.1 | Google Play Intel x86_64 Atom
      - android-36.1 | Pre-Release 16 KB Page Size Google Play Intel x86_64 Atom
      - android-37.0 | Google APIs Intel x86_64 Atom
    Android NDK: Not Found
  Windows SDK: Not Found
IDEs:
  Android Studio: AI-262.9437.185.2621.16467767
  Visual Studio: Not Found
Languages:
  Java:
    version: 17.0.20.1
    path: C:\Program Files\Microsoft\jdk-17.0.20.101-hotspot\bin\javac.EXE
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 19.2.3
    wanted: 19.2.3
  react-native:
    installed: 0.86.3
    wanted: 0.86.3
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Steps to reproduce

  1. Clone the reproducer branch, which is main at 2421ea7 with one file added, src/__tests__/native/attribute-query-in-is-where.test.tsx, and install:
    git clone --branch repro/541-is-where-attribute-queries https://github.com/YevheniiKotyrlo/react-native-css
    cd react-native-css
    yarn install
  2. Run yarn jest src/__tests__/native/attribute-query-in-is-where.test.tsx.

src/__tests__/native/attribute-query-in-is-where.test.tsx:

import { render, screen } from "@testing-library/react-native";
import { View } from "react-native-css/components/View";
import { registerCSS, testID } from "react-native-css/jest";

test.each([
  [".test:where([data-test='abc'])", "abc", true],
  [".test:where([data-test='abc'])", "xyz", false],
  [".test:is([data-test='abc'], [data-other='xyz'])", "abc", true],
  [".test:is([data-test='abc'])", "abc", true],
])("%s on data-test=%s matches: %s", (selector, value, expected) => {
  registerCSS(`${selector} { width: 37px; }`);
  render(<View testID={testID} className="test" dataSet={{ test: value }} />);
  expect(screen.getByTestId(testID).props.style?.width === 37).toBe(expected);
});

Expected: .test:where([data-test="abc"]) and .test:is([data-test="abc"], [data-other="xyz"]) match dataSet={{ test: "abc" }}, as in a browser.

Actual: neither matches.

The run's output on main at 2421ea7, Windows 11, Node 26.12.1
FAIL src/__tests__/native/attribute-query-in-is-where.test.tsx
  × .test:where([data-test='abc']) on data-test=abc matches: true (18 ms)
  √ .test:where([data-test='abc']) on data-test=xyz matches: false (4 ms)
  × .test:is([data-test='abc'], [data-other='xyz']) on data-test=abc matches: true (1 ms)
  √ .test:is([data-test='abc']) on data-test=abc matches: true (1 ms)
  ● .test:where([data-test='abc']) on data-test=abc matches: true
    expect(received).toBe(expected) // Object.is equality
    Expected: true
    Received: false
      11 |   registerCSS(`${selector} { width: 37px; }`);
      12 |   render(<View testID={testID} className="test" dataSet={{ test: value }} />);
    > 13 |   expect(screen.getByTestId(testID).props.style?.width === 37).toBe(expected);
         |                                                                ^
      14 | });
      15 |
      at toBe (src/__tests__/native/attribute-query-in-is-where.test.tsx:13:64)
  ● .test:is([data-test='abc'], [data-other='xyz']) on data-test=abc matches: true
    expect(received).toBe(expected) // Object.is equality
    Expected: true
    Received: false
      11 |   registerCSS(`${selector} { width: 37px; }`);
      12 |   render(<View testID={testID} className="test" dataSet={{ test: value }} />);
    > 13 |   expect(screen.getByTestId(testID).props.style?.width === 37).toBe(expected);
         |                                                                ^
      14 | });
      15 |
      at toBe (src/__tests__/native/attribute-query-in-is-where.test.tsx:13:64)
Test Suites: 1 failed, 1 total
Tests:       2 failed, 2 passed, 4 total
Snapshots:   0 total
Time:        1.049 s, estimated 2 s
Ran all test suites matching /src\\__tests__\\native\\attribute-query-in-is-where.test.tsx/i.

Reproducible example repository

https://github.com/YevheniiKotyrlo/react-native-css/tree/repro/541-is-where-attribute-queries

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions