Repository navigation
fix: steady the update check and list shared events once - #116
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for two problems in the published client:
nbtca updatefailed on slow connections without saying why, and the club calendar showed some events twice.Update check. It gave up after 3 seconds and printed only "无法检查更新". From this machine, 6 consecutive requests to the npm registry took 1.7 to 4.6 seconds, and one failed to connect, so two of the six would have failed the old check.
Duplicate events. The club feed carries the biweekly "NWDC (待定)" series twice, once from Apple Calendar and once from Google Calendar, under different UIDs. Every session appeared twice on Home and in the Events lists, and counted twice in the heatmap and star map. Occurrences with the same title, start, end, and location now appear once, and the heatmap subtracts the repeats from its counts. Removing one of the two series from the club calendar would fix the source.
Test. "spells the countdown out in Chinese" failed in
Pacific/Auckland, because its local-time fixture spans the start of New Zealand daylight saving time. It now uses+08:00times.Validation:
npm run checkpasses, and the full suite passes inAmerica/Los_Angeles,Pacific/Auckland,Asia/Kolkata, andUTC.nbtca events --monthagainst the live feed lists the 11-27 NWDC session once.