Skip to content

chore(deploy): label docker-compose.prod.yml as local prod-like harness (#203) - #362

Merged
nevridge merged 2 commits into
mainfrom
feature/label-prod-compose-as-local-harness
Oct 30, 2026
Merged

nevridge merged 2 commits into
mainfrom
feature/label-prod-compose-as-local-harness

Conversation

@nevridge

Copy link
Copy Markdown
Owner

Closes #203

Summary

docker-compose.prod.yml in this repo is not what Portainer runs. The real GitOps compose file is docker-compose.yml in nevridge/taskflow-deploy, and update-gitops only patches image tags there. The file was easy to mistake for production, which is how #183 got filed against a problem that did not exist.

This PR takes option 3 from the issue (document only). The file stays as a local prod-like harness and is now labeled as one. Nothing is reconciled or deleted.

What changed

  • docker-compose.prod.yml: a 5-line comment block at the top saying it is a local prod-like harness, not the production source of truth, and that the real file is docker-compose.yml in nevridge/taskflow-deploy. No service, env var, volume or label changed.
  • CLAUDE.md: the Commands label is now "local prod-like run; NOT the real production compose". The CI/CD GitOps sentence says the in-repo file is a local harness that differs from production and is not kept in sync.
  • README.md: the file tree entry is labeled as a local prod-like harness.
  • docs/DOCKER_CONFIGURATION.md, docs/DEPLOYMENT.md, docs/VOLUMES.md: each has a note near its first reference pointing to nevridge/taskflow-deploy as the source of truth. Statements that described production using values only in the local file are reworded: "no Seq, no frontend" and the taskflow-data-prod / taskflow-logs-prod volume names.
  • docs/DEPLOYMENT.md: the services table gets a caption only. The rows are not rewritten.

Wording stays general ("differs; see the deploy repo"). No list of specific production differences is copied in, because it could go stale.

No docker-compose.yml, other compose file, workflow or .claude/ file is touched. No headings are renamed, so anchors keep working. Every file that referenced docker-compose.prod.yml still does, and the TaskFlow.sln solution item stays.

Tests

No code changed, so there are no new automated tests. Verification was scripted instead. These results are from the test-verifier and validator agents, and CI will run the standard gates again.

  • docker compose -f docker-compose.prod.yml config exits 0, and its output is byte-identical to the pre-change baseline.
  • The compose diff is 5 added # lines and nothing removed.
  • git diff --name-only main...HEAD lists only the 6 files above.
  • dotnet format TaskFlow.sln --verify-no-changes exits 0.

Validator

Critical 0, Important 0, Minor 3. One rework pass already addressed wording findings (hedges on the volume-name statements, an ambiguous "Separate volumes" bullet, and the services-table caption).

Residual Minor findings, for awareness:

  • The statement that production uses taskflow-data and taskflow-logs comes from the issue. It was not checked against the deploy repo. Three of four mentions in VOLUMES.md carry a "see nevridge/taskflow-deploy for current values" hedge. The "Volume Names" bullet does not. Worth a one-time check against nevridge/taskflow-deploy.
  • The headings "Production Deployment" (DEPLOYMENT.md) and "For Docker Host Deployment (Production)" (VOLUMES.md) are unchanged by decision, each with a clarifying sentence under it.
  • The DEPLOYMENT.md table row "Local prod-like | Production builds" is mildly ambiguous. "Production builds" describes the build type.

Out of scope (not changed)

Reconciling or deleting the file, any change to nevridge/taskflow-deploy (the OTel endpoint path and ALLOWED_HOSTS are separate follow-ups to check against live Seq), ghcr-deploy.yml / update-gitops, CI drift detection, and prod healthcheck or volume renames.

@nevridge
nevridge force-pushed the feature/label-prod-compose-as-local-harness branch from 00eb48b to a1acf7b Compare October 30, 2026 23:12

@nevridge nevridge left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: 💬 Comments

No issues found in this diff.


Reviewed at 00eb48b · findings from pr-review + code-review, verified and triaged by @nevridge with Claude Code

@nevridge
nevridge merged commit 93f81e3 into main Oct 30, 2026
15 checks passed
@nevridge
nevridge deleted the feature/label-prod-compose-as-local-harness branch October 30, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: reconcile stale docker-compose.prod.yml with actual production (nevridge/taskflow-deploy)

1 participant