Repository navigation
chore(deploy): label docker-compose.prod.yml as local prod-like harness (#203) - #362
Merged
Merged
Conversation
nevridge
force-pushed
the
feature/label-prod-compose-as-local-harness
branch
from
October 30, 2026 23:12
00eb48b to
a1acf7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #203
Summary
docker-compose.prod.ymlin this repo is not what Portainer runs. The real GitOps compose file isdocker-compose.ymlinnevridge/taskflow-deploy, andupdate-gitopsonly patches image tags there. The file was easy to mistake for production, which is how #183 got filed against a problem that did not exist.This PR takes option 3 from the issue (document only). The file stays as a local prod-like harness and is now labeled as one. Nothing is reconciled or deleted.
What changed
docker-compose.prod.yml: a 5-line comment block at the top saying it is a local prod-like harness, not the production source of truth, and that the real file isdocker-compose.ymlinnevridge/taskflow-deploy. No service, env var, volume or label changed.CLAUDE.md: the Commands label is now "local prod-like run; NOT the real production compose". The CI/CD GitOps sentence says the in-repo file is a local harness that differs from production and is not kept in sync.README.md: the file tree entry is labeled as a local prod-like harness.docs/DOCKER_CONFIGURATION.md,docs/DEPLOYMENT.md,docs/VOLUMES.md: each has a note near its first reference pointing tonevridge/taskflow-deployas the source of truth. Statements that described production using values only in the local file are reworded: "no Seq, no frontend" and thetaskflow-data-prod/taskflow-logs-prodvolume names.docs/DEPLOYMENT.md: the services table gets a caption only. The rows are not rewritten.Wording stays general ("differs; see the deploy repo"). No list of specific production differences is copied in, because it could go stale.
No
docker-compose.yml, other compose file, workflow or.claude/file is touched. No headings are renamed, so anchors keep working. Every file that referenceddocker-compose.prod.ymlstill does, and theTaskFlow.slnsolution item stays.Tests
No code changed, so there are no new automated tests. Verification was scripted instead. These results are from the test-verifier and validator agents, and CI will run the standard gates again.
docker compose -f docker-compose.prod.yml configexits 0, and its output is byte-identical to the pre-change baseline.#lines and nothing removed.git diff --name-only main...HEADlists only the 6 files above.dotnet format TaskFlow.sln --verify-no-changesexits 0.Validator
Critical 0, Important 0, Minor 3. One rework pass already addressed wording findings (hedges on the volume-name statements, an ambiguous "Separate volumes" bullet, and the services-table caption).
Residual Minor findings, for awareness:
taskflow-dataandtaskflow-logscomes from the issue. It was not checked against the deploy repo. Three of four mentions inVOLUMES.mdcarry a "see nevridge/taskflow-deploy for current values" hedge. The "Volume Names" bullet does not. Worth a one-time check againstnevridge/taskflow-deploy.DEPLOYMENT.md) and "For Docker Host Deployment (Production)" (VOLUMES.md) are unchanged by decision, each with a clarifying sentence under it.DEPLOYMENT.mdtable row "Local prod-like | Production builds" is mildly ambiguous. "Production builds" describes the build type.Out of scope (not changed)
Reconciling or deleting the file, any change to
nevridge/taskflow-deploy(the OTel endpoint path andALLOWED_HOSTSare separate follow-ups to check against live Seq),ghcr-deploy.yml/update-gitops, CI drift detection, and prod healthcheck or volume renames.