Repository navigation
fix: clearer lookup failure reasons, more tests and upgrade notes - #125
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Merge Risk: 🟡 Moderate · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 17.24% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 29 functions across 5 files. (1 skipped: … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly summarizes the main changes: clearer lookup failure reasons, additional tests, and upgrade notes. Description check The description directly explains the lookup error handling, cancellation fix, upgrade-note changes, and added tests.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 17.24% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 29 functions across 5 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
- Fix all pre-merge checks with AI
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
413010c3-a363-4558-91b8-c03d66219912
📒 Files selected for processing: 6
README.mdhaproxy_agent.pytests/unit/conftest.pytests/unit/test_bind_mounts.pytests/unit/test_payload_validation.pytests/unit/test_requests.py
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Signed-off-by: Oleksandr Piskun <[email protected]>
cd6b7f7 to
52d34a7
Compare
1 participant
Follow-ups to #123 and #124.
When an ExApp lookup failed because the Kubernetes API answered with an error, the warning from #124 only said
HTTPServiceUnavailable: Service Unavailable, and a total timeout ended inTimeoutError:with nothing after it. The warning now gives the error's text, or only its type when there is no message. If one of several requests waiting for the same lookup is cancelled, the lookup itself no longer fails withInvalidStateError.The README's upgrade notes now say that a daemon whose Docker network name is empty or has a blank, a
:or a control character is refused (a refused update leaves the ExApp without a container), and that recovering from a failed ExApp update needs the deploy options again and is not done by rolling HaRP back.New tests cover mount modes other than
roandrw(the rules and the request to Docker treat them as read-write), the length limits at their boundary and the lookup cases above. The test fixture now also clears the negative lookup cache and checks after each test that no lookup is left in flight.