Repository navigation
fix(federation): resolve federated storage for local reshares - #6249
Open
ArtificialOwl wants to merge 1 commit into
Open
ArtificialOwl wants to merge 1 commit into
ArtificialOwl wants to merge 1 commit into
Conversation
Signed-off-by: Maxence Lange <[email protected]> Assisted-by: ClaudeCode:claude-opus-5-5
ArtificialOwl
force-pushed
the
fix/noid/extract-owner-from-local-share
branch
from
October 29, 2026 19:32
9ae9cec to
8297fa9
Compare
ArtificialOwl
marked this pull request as ready for review
October 29, 2026 19:40
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a file received through a federated share is reshared locally, the recipient's copy sits on a shared storage that wraps the federated one.
FederationService::getRemoteRedirectURL()detected that storage as federated, but read the remote server, the share token and the file path from the recipient's wrapping storage. For a single reshared file that path is empty, so the remote server opened the root of the federated share instead of the file.Permissions still come from the recipient's own copy. The access token sent to the remote server takes its write flag from that copy, and the remote server removes edit rights when the flag is off, so a read-only local reshare stays read-only.
Other changes:
getRemoteRedirectURL()now declares a?stringreturn type.SharingExternalStoragereference.TODO
Checklist
has been updatedor is not requiredAI (if applicable)
🤖 Generated with Claude Code