Skip to content

feat(import): Provide extended import report - #3071

Open
Koc wants to merge 1 commit into
mainfrom
feature/extended-import-report
Open

feat(import): Provide extended import report#3071
Koc wants to merge 1 commit into
mainfrom
feature/extended-import-report

Conversation

@Koc

@Koc Koc commented Oct 11, 2026 •
edited by jospoortvliet
Loading

Copy link
Copy Markdown
Contributor

Part of #880

Collect and list failed rows and columns instead of just counting

🖼️ Screenshots

Report for synchronously imported small file without errors
image

Report for synchronously imported small file
image

Activity for table
image

Global activity
image

Csv report (stored in user Tables/Imports directory)
image

Notification for asynchronously imported large file
image

  • Activity: successful imports now produce audit entries for both sync and async imports, with the same table-owner/sharee recipients. Import statistics and report links are visible only to the importer. Failed async imports now produce importer-only activity.
  • Notifications: remain async-only and importer-only, but now include import statistics and a problems-report link when available, or a safe user-facing failure reason.
  • Report stored in Tables/Import subfolder of the importer for imports with errors.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stableX.X
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

closes #3168

@Koc
Koc force-pushed the feature/extended-import-report branch 17 times, most recently from 31c2ea6 to 76676f3 Compare October 11, 2026 21:36
@Koc
Koc marked this pull request as ready for review October 11, 2026 21:47
@Koc
Koc requested review from blizzz and enjeck as code owners October 11, 2026 21:47
@Koc
Koc requested a review from samin-z October 11, 2026 21:47
enjeck
enjeck reviewed Oct 12, 2026
View reviewed changes
Comment thread lib/Activity/TablesProvider.php Resolved
Comment thread lib/Activity/ActivityManager.php Resolved
Comment thread lib/Activity/ActivityManager.php Resolved
Comment thread lib/BackgroundJob/ImportTableJob.php Resolved
Comment thread lib/BackgroundJob/ImportTableJob.php Resolved
Comment thread lib/Service/ImportService.php Resolved
Comment thread lib/Service/ImportService.php Resolved
Comment thread lib/Service/ImportService.php Resolved
@Koc
Koc force-pushed the feature/extended-import-report branch 3 times, most recently from e4950f8 to ad82a71 Compare October 12, 2026 22:06
@Koc

Koc commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

@enjeck I've fixed code review comments, please check one more time

enjeck
enjeck reviewed Oct 18, 2026
View reviewed changes
Comment thread lib/Service/ImportService.php Resolved
enjeck
enjeck reviewed Oct 18, 2026
View reviewed changes
Comment thread lib/Service/ImportService.php Resolved
Comment thread lib/Service/ImportService.php Resolved
Comment thread lib/Service/ImportService.php Resolved
Comment thread lib/Service/ImportService.php
$this->addProblem($rowId ? ImportProblem::CODE_ROW_UPDATE_FAILED : ImportProblem::CODE_ROW_INSERT_FAILED, $row->getRowIndex());
} catch (NotFoundError $e) {
$this->logger->error($e->getMessage(), ['exception' => $e]);
throw new NotFoundError(static::class . ' - ' . __FUNCTION__ . ': ' . $e->getMessage(), 0, $e);

@enjeck enjeck Oct 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we save the report before throwing?

@Koc Koc Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO there is no sense to store report if we can't start import. Report is for rows, but here we have generic error. For this case we will provide error in the response:

image

@jospoortvliet jospoortvliet mentioned this pull request Oct 26, 2026
Open
@Koc
Koc force-pushed the feature/extended-import-report branch from ad82a71 to cfe2e83 Compare October 28, 2026 18:41
@Koc
Koc force-pushed the feature/extended-import-report branch from cfe2e83 to 5f538c1 Compare October 28, 2026 19:08
@Koc
Koc force-pushed the feature/extended-import-report branch from 5f538c1 to 84dc544 Compare October 28, 2026 19:17
@Koc

Koc commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

@enjeck please re-review one more time with fixes. I did also rebase and conflicts resolution

@jospoortvliet jospoortvliet added enhancement New feature or request import/export labels Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enjeck enjeck enjeck left review comments
@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner
@samin-z samin-z Awaiting requested review from samin-z

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request import/export

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve import error reporting

3 participants

@Koc @enjeck @jospoortvliet