Skip to content

fix(settings): enable screen lock timeout dropdown when screen lock is toggled on - #6983

Merged
mahibi merged 1 commit into
masterfrom
fixDisplayLockSelections
Nov 2, 2026
Merged

mahibi merged 1 commit into
masterfrom
fixDisplayLockSelections

Conversation

@mahibi

@mahibi mahibi commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

The dropdown was only enabled in setupScreenLockSetting() based on the initial state. Toggling screen lock on afterwards re-enabled the container but left the dropdown disabled, so it could not be expanded.

Assisted-by: Claude Code:claude-opus-5

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

…s toggled on

The dropdown was only enabled in setupScreenLockSetting() based on the
initial state. Toggling screen lock on afterwards re-enabled the
container but left the dropdown disabled, so it could not be expanded.

Assisted-by: Claude Code:claude-opus-5
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi added this to the 26.0.0 milestone Oct 30, 2026
@mahibi mahibi self-assigned this Oct 30, 2026
@mahibi mahibi added the 3. to review Waiting for reviews label Oct 30, 2026
@mahibi
mahibi requested a review from rapterjet2004 October 30, 2026 17:02
@github-actions

Copy link
Copy Markdown
Contributor

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit c195876
Version 6983
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@mahibi
mahibi merged commit 5e4f040 into master Nov 2, 2026
20 of 21 checks passed
@mahibi
mahibi deleted the fixDisplayLockSelections branch November 2, 2026 09:26
@mahibi

mahibi commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-25.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants