Repository navigation
Fix misc flaky tests - #9477
Merged
Merged
Fix misc flaky tests#9477
Conversation
Signed-off-by: silver <[email protected]> Assisted-by: ClaudeCode:claude-opus-5.5
Preview generation after saving can briefly lock the file, so the WebDAV MOVE fails with a 500 LockedException. The response was not checked, so the test only failed later when opening the renamed file. Check for 201 and retry for up to 10 seconds. Signed-off-by: silver <[email protected]> Assisted-by: ClaudeCode:claude-opus-5.5
The caret label with the user name is rendered inline in the text, so screen readers read it as part of the content, e.g. a heading "Hello world" became "Hello wo alice rld". Signed-off-by: silver <[email protected]> Assisted-by: ClaudeCode:claude-opus-5.5
When the pending autosave timer fired, pendingAutosave was not reset. If that save failed (e.g. while offline), no new retry was scheduled and autosave stopped until the user typed again. Also log the retry delay in seconds instead of milliseconds. Signed-off-by: silver <[email protected]> Assisted-by: ClaudeCode:claude-opus-5.5
benjaminfrueh
approved these changes
Oct 27, 2026
Collaborator
Author
|
/backport to stable35 |
Collaborator
Author
|
/backport to stable34 |
Collaborator
Author
|
/backport to stable33 |
3 tasks
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes flaky Playwright and Cypress tests. Two of the causes were real app bugs, not just test issues.
autosave.spec.ts› "saves after being disconnected for 2 minutes".conflict.spec.ts› "… after reopening the editor" when a stale session's caret landed inside the heading.change-mime-type.spec.tsfailed with a 500LockedException. The response wasn't checked, so the test only failed later. It now checks for 201 and retries for up to 10 s.attachments.spec.js› "Insert an image file from Files" and the follow-up "attachment files are in the attachment folder" failure.🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)