Repository navigation
Adding Measure Frequency in NI-DMM - #2226
Draft
NI-velmurugan wants to merge 8 commits into
Draft
NI-velmurugan wants to merge 8 commits into
NI-velmurugan wants to merge 8 commits into
Conversation
Contributor
Author
|
@divakar-selvam07 the PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (75.14%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #2226 +/- ##
===========================================
- Coverage 88.11% 75.14% -12.98%
===========================================
Files 88 58 -30
Lines 22832 10868 -11964
===========================================
- Hits 20119 8167 -11952
+ Misses 2713 2701 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Avinash2Suresh
approved these changes
Oct 21, 2026
Contributor
|
@jarnoldNI , the PR is ready for your review. |
jarnoldNI
reviewed
Oct 22, 2026
| with nidmm.Session(resource_name=resource_name, options=options) as session: | ||
| session.configure_measurement_digits(measurement_function=nidmm.Function[function], range=range, resolution_digits=RESOLUTION_DIGITS) | ||
| session.freq_voltage_range = max_amplitude | ||
| # The driver reports warnings through Python's warnings module; the warning code is included in the message. |
There was a problem hiding this comment.
Suggested change
| # The driver reports warnings through Python's warnings module; the warning code is included in the message. | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
This PR adds
nidmm_measure_frequency.py, a Python adaptation of the LabVIEWMeasure Frequency.viWhat testing has been done?
Manually tested the example only using simulated hardware and the real hardware.