Skip to content

lookup: skip Node.js <24 for lru-cache - #1228

Open
MikeMcC399 wants to merge 1 commit into
nodejs:mainfrom
MikeMcC399:skip/lt-24-lru-cache
Open

MikeMcC399 wants to merge 1 commit into
nodejs:mainfrom
MikeMcC399:skip/lt-24-lru-cache

Conversation

@MikeMcC399

Copy link
Copy Markdown
Contributor

Situation

Running citgm lru-cache fails:

  • on Node.js 22 for macos, windows & ubuntu

Although the package.json of [email protected] sets:

  "engines": {
    "node": "20 || >=22"
  },

its own CI tests in https://github.com/isaacs/node-lru-cache/blob/main/.github/workflows/ci.yml already dropped Node.js 22 and only run in Node.js 24 & 25. Repo tests are not compatible with Node.js 22 and need to be skipped.

Change

Add a skip for Node.js <24 to lru-cache in lookup.json.

Checklist
  • npm test passes
  • contribution guidelines followed
    here

@codecov-commenter

codecov-commenter commented Oct 31, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.11%. Comparing base (147e8d8) to head (449e614).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1228   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2127     2127           
  Misses         86       86           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MikeMcC399
MikeMcC399 marked this pull request as ready for review October 31, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lru-cache fails on Node.js 22

2 participants