Repository navigation
fix(react): give llms-txt-full a Markdown pipeline - #1164
Merged
Merged
Conversation
#1157 removed `@doc-kit/core/utils/remark.mjs`, which `llms-txt-full` (#1127) still imported, so loading the generator failed on main. The generator now declares its own `markdown` pipeline and serialises pages with `getProcessor('llms-txt-full')`, as `json` does. The pipeline names `remark-gfm` and `remark-stringify`, so the react package depends on them directly. Assisted-by: Claude Sonnet 5.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
Member
Author
|
Howdy @nodejs/web-infra I'm merging this as a hot-fix to failing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1164 +/- ##
==========================================
+ Coverage 91.38% 93.32% +1.93%
==========================================
Files 273 273
Lines 27000 27050 +50
Branches 2676 2722 +46
==========================================
+ Hits 24674 25244 +570
+ Misses 2303 1784 -519
+ Partials 23 22 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| File | Main | PR | Change |
|---|---|---|---|
orama-db.json |
9.57 MB | 9.57 MB | -1.00 B (-0.0%) |
Performance estimate (single CI run)
- Generation time: 34.6% faster (9.54 s → 6.24 s)
- Peak memory: 2.6% higher (1.74 GB → 1.78 GB)
web Generator
Performance estimate (single CI run)
- Generation time: 55.5% slower (39.95 s → 62.11 s)
- Peak memory: 15.8% lower (3.96 GB → 3.34 GB)
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the failing tests on
mainby giving thellms-txt-fullgenerator its own Markdown pipeline.#1157 removed
@doc-kit/core/utils/remark.mjs, butllms-txt-full(#1127) had already landed and still importedgetRemarkandgetRemarkMdxfrom it, so loading the generator threwERR_MODULE_NOT_FOUND.llms-txt-fulldeclares amarkdownpipeline (type annotations, GFM andremark-stringify), the same wayjsonserialises Markdown, andbuildPagesnow usesgetProcessor('llms-txt-full', { mdx }).@doc-kit/generator-reactdepends onremark-gfmandremark-stringifydirectly, as pipeline specifiers resolve from the module declaring them and pnpm doesn't hoist them into the package.llms-txt-fulltests load the generator's pipeline first, like the tests of the other generators do since feat: add amarkdownoption for remark, rehype, and recma plugins #1157.No changeset, since
llms-txt-fullis unreleased and.changeset/llms-full.mdalready covers it.Validation
The failing run had three failing test files:
packages/core/src/generators/__tests__/index.test.mjsand bothllms-txt-fulltests. All 736 tests pass now, andlintis clean.I added two
buildPagestests, one for type annotations and one for an MDX element, so the pipeline declaration is covered (themdxbranch had no test before). I also randoc-kit generate -t llms-txt-fullondoc/api/path.mdand{string}annotations and code blocks still serialise as before.The lockfile change is only the two new importer entries for
packages/react.Related Issues
Refs: #1127, #1157
Check List
node --run testand all tests passed.node --run format:check&node --run lint.