Skip to content

fix(react): give llms-txt-full a Markdown pipeline - #1164

Merged
ovflowd merged 1 commit into
mainfrom
fix/llms-txt-full-markdown-pipeline
Oct 10, 2026
Merged

ovflowd merged 1 commit into
mainfrom
fix/llms-txt-full-markdown-pipeline

Conversation

@ovflowd

@ovflowd ovflowd commented Oct 10, 2026

Copy link
Copy Markdown
Member

Description

This PR fixes the failing tests on main by giving the llms-txt-full generator its own Markdown pipeline.

#1157 removed @doc-kit/core/utils/remark.mjs, but llms-txt-full (#1127) had already landed and still imported getRemark and getRemarkMdx from it, so loading the generator threw ERR_MODULE_NOT_FOUND.

  • llms-txt-full declares a markdown pipeline (type annotations, GFM and remark-stringify), the same way json serialises Markdown, and buildPages now uses getProcessor('llms-txt-full', { mdx }).
  • @doc-kit/generator-react depends on remark-gfm and remark-stringify directly, as pipeline specifiers resolve from the module declaring them and pnpm doesn't hoist them into the package.
  • Both llms-txt-full tests load the generator's pipeline first, like the tests of the other generators do since feat: add a markdown option for remark, rehype, and recma plugins #1157.

No changeset, since llms-txt-full is unreleased and .changeset/llms-full.md already covers it.

Validation

The failing run had three failing test files: packages/core/src/generators/__tests__/index.test.mjs and both llms-txt-full tests. All 736 tests pass now, and lint is clean.

I added two buildPages tests, one for type annotations and one for an MDX element, so the pipeline declaration is covered (the mdx branch had no test before). I also ran doc-kit generate -t llms-txt-full on doc/api/path.md and {string} annotations and code blocks still serialise as before.

The lockfile change is only the two new importer entries for packages/react.

Related Issues

Refs: #1127, #1157

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format:check & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

#1157 removed `@doc-kit/core/utils/remark.mjs`, which `llms-txt-full`
(#1127) still imported, so loading the generator failed on main.

The generator now declares its own `markdown` pipeline and serialises
pages with `getProcessor('llms-txt-full')`, as `json` does. The pipeline
names `remark-gfm` and `remark-stringify`, so the react package depends
on them directly.

Assisted-by: Claude Sonnet 5.5 <[email protected]>
@vercel

vercel Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-docs-tooling Ready Ready Preview Oct 10, 2026 11:38am UTC

Request Review

@ovflowd
ovflowd requested a review from a team as a code owner October 10, 2026 11:37
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Failed ❌

View logs ↗
43a9c35 2026-10-10T11:38:17.362Z View logs ↗

@ovflowd

ovflowd commented Oct 10, 2026

Copy link
Copy Markdown
Member Author

Howdy @nodejs/web-infra I'm merging this as a hot-fix to failing main CI tests. Please feel free to approve retroactively or scrutinize/give feedback review later.

@ovflowd ovflowd added the fast track This PR can land before the typical review time, with a :+1: from collaborators label Oct 10, 2026
@codecov

codecov Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.32%. Comparing base (802ba72) to head (43a9c35).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1164      +/-   ##
==========================================
+ Coverage   91.38%   93.32%   +1.93%     
==========================================
  Files         273      273              
  Lines       27000    27050      +50     
  Branches     2676     2722      +46     
==========================================
+ Hits        24674    25244     +570     
+ Misses       2303     1784     -519     
+ Partials       23       22       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

api-links Generator

Performance estimate (single CI run)

  • Generation time: 0.7% slower (1.51 s → 1.52 s)
  • Peak memory: 1.4% lower (424.70 MB → 418.70 MB)

json Generator

Performance estimate (single CI run)

  • Generation time: 3.1% faster (9.37 s → 9.08 s)
  • Peak memory: 24.8% higher (1.46 GB → 1.83 GB)

legacy-html Generator

Performance estimate (single CI run)

  • Generation time: 42.3% slower (21.71 s → 30.89 s)
  • Peak memory: 6.0% lower (2.47 GB → 2.32 GB)

legacy-json Generator

Performance estimate (single CI run)

  • Generation time: 9.0% slower (8.34 s → 9.09 s)
  • Peak memory: 8.1% lower (1.70 GB → 1.56 GB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 6.4% faster (8.24 s → 7.71 s)
  • Peak memory: 11.0% higher (1.43 GB → 1.59 GB)

orama-db Generator

Output size: 1 file changed · net -1.00 B

File size details
File Main PR Change
orama-db.json 9.57 MB 9.57 MB -1.00 B (-0.0%)

Performance estimate (single CI run)

  • Generation time: 34.6% faster (9.54 s → 6.24 s)
  • Peak memory: 2.6% higher (1.74 GB → 1.78 GB)

web Generator

Performance estimate (single CI run)

  • Generation time: 55.5% slower (39.95 s → 62.11 s)
  • Peak memory: 15.8% lower (3.96 GB → 3.34 GB)

@ovflowd
ovflowd merged commit de88b03 into main Oct 10, 2026
26 of 27 checks passed
@ovflowd
ovflowd deleted the fix/llms-txt-full-markdown-pipeline branch October 10, 2026 11:41

This branch was successfully deployed

1 active deployment
Preview – api-docs-tooling — 43a9c35e Deployed Oct 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast track This PR can land before the typical review time, with a :+1: from collaborators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant