src: remove orphaned js_udp_wrap test binding - #66399
Open
Renegade334 wants to merge 1 commit into
Open
Renegade334 wants to merge 1 commit into
Renegade334 wants to merge 1 commit into
Conversation
Signed-off-by: Renegade334 <[email protected]>
Collaborator
|
Review requested:
|
lpinca
approved these changes
Sep 29, 2026
Collaborator
Member
|
Is this something that would be used/useful for the upcoming QUIC work? Asking because the TCP equivalent is for HTTP/1.1 and HTTP/2 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66399 +/- ##
==========================================
+ Coverage 90.38% 90.40% +0.02%
==========================================
Files 792 791 -1
Lines 275517 275392 -125
Branches 52813 52788 -25
==========================================
- Hits 249017 248965 -52
+ Misses 16912 16840 -72
+ Partials 9588 9587 -1
🚀 New features to boost your workflow:
|
Member
Author
I'm fairly confident that the answer is no, Brand New Quic™ endpoints don't wrap UDP handles in the JS layer like the mothballed implementation did, they initialise and store their own private Endpoint::UDP handles in C++. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test-only js_udp_wrap binding was added in #33380, and the test utility it backed was removed in #54825, leaving it orphaned.
It is not visible via
process.binding(), so removing it should be a formality.