Repository navigation
Conversation
Assisted-by: Codex Signed-off-by: Efe Karasakal <[email protected]>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66650 +/- ##
========================================
Coverage 90.45% 90.46%
========================================
Files 791 791
Lines 276816 277092 +276
Branches 53197 53278 +81
========================================
+ Hits 250403 250668 +265
- Misses 16822 16825 +3
- Partials 9591 9599 +8
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QUIC error codes in
RESET_STREAM,STOP_SENDING, andCONNECTION_CLOSEframes use the variable length integer (limiting them 0 through through 2^62 - 1) encoding defined by RFC 9000 (see 16, also 19.4, 19.5 and 19.19)This change introduces a shared error code validation for the error codes. This also simplifies
streams.ccbecause StopSending and ResetStream are exposed to and only used by JS. The native methods therefore no longer need to handle omitted values.AI assistance was used in code and docs generation