Repository navigation
deps: update v8 to 15.7 - #66799
Open
legendecas wants to merge 11 commits into
Open
deps: update v8 to 15.7#66799legendecas wants to merge 11 commits into
legendecas wants to merge 11 commits into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Collaborator
Collaborator
Collaborator
Member
Author
|
Continuing in #67070 for V8 v15.8. |
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 15.7. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/8533406 Signed-off-by: Joyee Cheung <[email protected]> PR-URL: nodejs#66601 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Original commit message:
[platform] support madvise(3C) across ALL illumos revisions
In illumos, madvise(3C) now takes `void *` for its first argument
post-illumos#14418, but uses `caddr_t` pre-illumos#14418. This fix will
detect if the illumos mman.h file in use is pre-or-post-illumos#14418 so
builds can work either way.
Co-Authored-By: Dan McDonald <[email protected]>
Refs: nodejs#65161
Change-Id: I87faa4e7042cf9b02449bd3debfdd7fed30e5d3c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8532506
Reviewed-by: Michael Lippautz <[email protected]>
Commit-Queue: Joyee Cheung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#111024}
Refs: v8/v8@5dea94c
Original commit message:
[sandbox] fix dispatch table access on illumos
illumos pointers are VA48, can allocate from the top of the 64-bit range
as well.
Co-Authored-By: Dan McDonald <[email protected]>
Refs: nodejs#65161
Change-Id: I7d803ca0da2ab6c7cc206cb964d63683523a13da
Refs: v8/v8@011b2de
Original commit message:
Do not use preserve_most when targeting the MSVC ABI
In the Microsoft C++ ABI, because preserve_most changes the calling
convention, clang mangles it with U while cdecl gets an A, which
means components compiled with different toolchains can fail to link.
Make it a no-op when targeting MSVC and its ABI.
Co-Authored-By: Stefan Stojanovic <[email protected]>
Refs: nodejs#55784
Change-Id: I67b49e739942d4026ac060be35bb39ec22256cbd
Refs: v8/v8@7d7e8c2
Original commit message:
[tracing] do not define legacy tracing classes when using Perfetto
Otherwise the Windows build of Node.js fails with `undefined symbol`
errors due to the missing destructor.
Change-Id: Id0841aed2f0a8f0cfe8889c39150552e31ee5f96
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8580049
Reviewed-by: Yang Guo <[email protected]>
Reviewed-by: Chengzhong Wu <[email protected]>
Commit-Queue: Chengzhong Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#110947}
Refs: v8/v8@785a2ea
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8459484 Signed-off-by: Joyee Cheung <[email protected]>
legendecas
marked this pull request as ready for review
October 29, 2026 15:09
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66799 +/- ##
==========================================
+ Coverage 90.66% 90.69% +0.02%
==========================================
Files 797 797
Lines 278791 278773 -18
Branches 53620 53604 -16
==========================================
+ Hits 252768 252820 +52
+ Misses 16376 16302 -74
- Partials 9647 9651 +4 🚀 New features to boost your workflow:
|
Member
Author
|
Updated this PR to the stable branch of V8 15.7. |
richardlau
added
the
semver-major
Collaborator
Member
Author
|
|
Member
Author
Collaborator
Collaborator
Member
Author
Build failed on power9le and s390x /cc @nodejs/platform-s390 @nodejs/platform-ppc |
Member
|
@legendecas I think we need to mirror the change from a3fe991 / https://chromium-review.googlesource.com/c/v8/v8/+/8524366 in Line 73 in 8d514c7 i.e. change v8_use_metagen_instance_types=false to v8_use_metagen=false.
|
Member
Author
|
Hmm maybe a3fe991 is not enough. I'll take a look tomorrow. |
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8524366 Signed-off-by: Joyee Cheung <[email protected]> Signed-off-by: Chengzhong Wu <[email protected]>
Member
That only updates the gyp based build used by Node.js. The V8 CI runs V8's gn based build. FWIW in https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7472/consoleFull we can see |
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected V8 v15.7 Stable Release: Nov 3, 2026.
Non-blocking upstream CLs: