Skip to content

tools: update gyp-next to 0.22.4 - #66988

Open
nodejs-github-bot wants to merge 2 commits into
mainfrom
actions/tools-update-gyp-next
Open

nodejs-github-bot wants to merge 2 commits into
mainfrom
actions/tools-update-gyp-next

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

This is an automated update of gyp-next to 0.22.4.

@nodejs-github-bot nodejs-github-bot added gyp Issues and PRs related to GYP and .gyp or .gypi build files. tools Issues and PRs related to the tools directory. labels Oct 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 25, 2026
@codecov

codecov Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.59%. Comparing base (45ae12c) to head (d35c9b5).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66988      +/-   ##
==========================================
+ Coverage   90.58%   90.59%   +0.01%     
==========================================
  Files         797      797              
  Lines      278376   278376              
  Branches    53524    53537      +13     
==========================================
+ Hits       252160   252198      +38     
+ Misses      16584    16570      -14     
+ Partials     9632     9608      -24     

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 and others added 2 commits October 25, 2026 09:48
They are not maintained in this repository.

Signed-off-by: Antoine du Hamel <[email protected]>
@aduh95
aduh95 force-pushed the actions/tools-update-gyp-next branch from 7b960eb to d35c9b5 Compare October 25, 2026 08:48
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 25, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 27, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

Commit Queue failed

This pull request has multiple commits, but no landing policy was selected.

Add commit-queue-squash PRs the Commit Queue should land as one squashed commit. to land it as one commit, or commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. to land the commits separately.

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
�[36m⠋�[39m Loading data for nodejs/node/pull/66988
�[36m⠋�[39m Loading data for nodejs/node/pull/66988
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/66988
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66988
�[36m⠋�[39m Getting comments from nodejs/node/pull/66988
�[36m⠋�[39m Getting commits from nodejs/node/pull/66988
✔  Done loading data for nodejs/node/pull/66988
----------------------------------- PR info ------------------------------------
Title      tools: update gyp-next to 0.22.4 (#66988)
   ⚠  Could not retrieve the email or name of the PR's author from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-gyp-next -> nodejs:main
Labels     build, tools, author ready, needs-ci, gyp, commit-queue
Commits    2
 - tools: do not lint GYP JS files
 - tools: update gyp-next to 0.22.4
Committers 1
 - Antoine du Hamel <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/66988
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/66988
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 25 Oct 2026 00:54:22 GMT
   ✔  Approvals: 3
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/66988#pullrequestreview-5643233298
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/66988#pullrequestreview-5643973862
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/66988#pullrequestreview-5645239563
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-10-25T16:00:16Z: https://ci.nodejs.org/job/node-test-pull-request/78644/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78644/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78644/
�[36m⠙�[39m Querying API for job/node-test-pull-request/78644/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
�[36m⠹�[39m Bringing origin/main up to date...
�[36m⠹�[39m Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   578d081148..640ce854c5  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - a72c340824 deps: update zlib to 1.3.2.1-motley-9f9f52c
 - 640ce854c5 deps: update zlib to 1.3.2.1-motley-9f9f52c
--------------------------------------------------------------------------------
HEAD is now at 640ce854c5 deps: update zlib to 1.3.2.1-motley-9f9f52c
   ✔  Reset to origin/main
�[36m⠸�[39m Downloading patch for 66988
�[36m⠸�[39m Downloading patch for 66988
From https://github.com/nodejs/node
 * branch                  refs/pull/66988/merge -> FETCH_HEAD
✔  Fetched commits as ddba9a535f5e..d35c9b5d7c39
--------------------------------------------------------------------------------
[main 26ea1f1900] tools: do not lint GYP JS files
 Author: Antoine du Hamel <[email protected]>
 Date: Sun Oct 25 09:47:47 2026 +0100
 1 file changed, 1 insertion(+)
[main df0c99ba89] tools: update gyp-next to 0.22.4
 Date: Sun Oct 25 00:54:19 2026 +0000
 13 files changed, 189 insertions(+), 15 deletions(-)
 rename tools/gyp/{commitlint.config.mjs => commitlint.config.js} (100%)
 create mode 100644 tools/gyp/test/fixtures/pch_action.h
 create mode 100644 tools/gyp/test/fixtures/pch_asm.S
 create mode 100644 tools/gyp/test/fixtures/pch_dep.h
 create mode 100644 tools/gyp/test/fixtures/pch_prefix.gyp
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
(node:1460) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/4)

�[KExecuting: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: do not lint GYP JS files

They are not maintained in this repository.

Signed-off-by: Antoine du Hamel <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/66988
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
--------------------------------------------------------------------------------
[detached HEAD d29590ef96] tools: do not lint GYP JS files
 Author: Antoine du Hamel <[email protected]>
 Date: Sun Oct 25 09:47:47 2026 +0100
 1 file changed, 1 insertion(+)
Rebasing (3/4)
Rebasing (4/4)

�[KExecuting: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: update gyp-next to 0.22.4

PR-URL: https://github.com/nodejs/node/pull/66988
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
--------------------------------------------------------------------------------
[detached HEAD ef77393695] tools: update gyp-next to 0.22.4
 Date: Sun Oct 25 00:54:19 2026 +0000
 13 files changed, 189 insertions(+), 15 deletions(-)
 rename tools/gyp/{commitlint.config.mjs => commitlint.config.js} (100%)
 create mode 100644 tools/gyp/test/fixtures/pch_action.h
 create mode 100644 tools/gyp/test/fixtures/pch_asm.S
 create mode 100644 tools/gyp/test/fixtures/pch_dep.h
 create mode 100644 tools/gyp/test/fixtures/pch_prefix.gyp

�[KSuccessfully rebased and updated refs/heads/main.
--------------------------------------------------------------------------------
   ℹ  Add `commit-queue-squash` label to land the PR as one commit, or `commit-queue-rebase` to land as separate commits.

View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. gyp Issues and PRs related to GYP and .gyp or .gypi build files. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants