Repository navigation
Conversation
nodejs-github-bot
added
needs-ci
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
The subtest watched all of tmpdir, so files created there by the subtests running alongside it restarted the child and broke its output. The fix is to watch a directory of its own instead to not conflict. Refs: nodejs#66232 Assisted-by: Claude Signed-off-by: Farid Zakaria <[email protected]>
fzakaria
force-pushed
the
test-watch-mode-env-file
branch
from
October 27, 2026 00:36
ec3da27 to
6a0265a
Compare
Author
|
Context: I found the race behind this by running the test under Rewind VM |
fzakaria
added a commit
to fzakaria/rewindvm
that referenced
this pull request
Oct 27, 2026
Rewind found test-watch-mode's --env-file-if-exists subtest failing in 34 of 514 runs: it watched the shared tmpdir, so files the subtests running beside it created restarted its child. The fix is nodejs/node#67041. List Node after Go, keeping the best known projects first. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subtest watched all of tmpdir, so files created there by the subtests running alongside it restarted the child and broke its output. The fix is to watch a directory of its own instead to not conflict.
Similar to: #66232