Skip to content

ffi: reject multi-argument buffer fast trampolines #67046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trivikr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ffi: reject multi-argument buffer fast trampolines #67046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/ffi/platforms/arm64.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,11 @@ extern "C" bool node_ffi_create_fast_trampoline(
if (has_buffer_args && fp_count != 0) {
return false;
}
// The buffer helper call clobbers target registers already loaded for
// earlier arguments, so buffer trampolines support a single argument only.
if (has_buffer_args && argc > 1) {
return false;
}

const size_t incoming_gp_count = gp_count + (has_buffer_args ? 1 : 0);
// When V8 passes FastApiCallbackOptions, it consumes one additional GP
Expand Down
5 changes: 5 additions & 0 deletions src/ffi/platforms/x64.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,11 @@ extern "C" bool node_ffi_create_fast_trampoline(
if (has_buffer_args && fp_count != 0) {
return false;
}
// The buffer helper call clobbers target registers already loaded for
// earlier arguments, so buffer trampolines support a single argument only.
if (has_buffer_args && argc > 1) {
return false;
}

const size_t incoming_gp_count = gp_count + (has_buffer_args ? 1 : 0);
// rdi is occupied by the V8 receiver, leaving rsi, rdx, rcx, r8, and r9 for
Expand Down
Loading