Repository navigation
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
inoway46
force-pushed
the
fix-http2-final-response-memory
branch
2 times, most recently
from
October 31, 2026 17:30
0edc48e to
c90f4ac
Compare
inoway46
changed the title
inoway46
force-pushed
the
fix-http2-final-response-memory
branch
from
November 1, 2026 03:39
c90f4ac to
0f87053
Compare
Allow clients to receive responses when queued request data exceeds maxSessionMemory, while preserving limits on received headers. Fixes: nodejs#66739 Refs: nodejs#67113 Assisted-by: Codex Signed-off-by: inoway46 <[email protected]>
inoway46
force-pushed
the
fix-http2-final-response-memory
branch
from
November 1, 2026 03:51
0f87053 to
151b1b8
Compare
inoway46
marked this pull request as ready for review
November 1, 2026 04:14
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67114 +/- ##
==========================================
+ Coverage 90.67% 90.69% +0.01%
==========================================
Files 797 797
Lines 278789 278805 +16
Branches 53609 53618 +9
==========================================
+ Hits 252798 252860 +62
+ Misses 16342 16306 -36
+ Partials 9649 9639 -10
🚀 New features to boost your workflow:
|
mcollina
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A server can reject a request with an early response, such as
413 Payload Too Large, while the request body is still queued on the client. If that queued data exhaustsmaxSessionMemory, the client rejects the response headers withERR_HTTP2_STREAM_ERRORinstead of delivering the response to the application.Exclude session-wide queued outbound DATA from incoming header memory checks on locally initiated client streams, including informational responses and trailers. This allows the client to receive the response while the request body remains queued, provided the remaining counted memory stays within the session budget. This follows the client-side, locally initiated stream scope suggested in #66739 (comment), while retaining memory checks for received headers.
Retained headers, including informational responses, still count towards the session budget. Repeated 1xx responses therefore remain subject to the cumulative header memory limit. Header count and size limits, server-side checks, push stream checks, and new stream admission are unchanged.
Add regression coverage for early responses, informational responses, trailers, retained headers, and header limits. Strengthen the cancellation test to verify memory accounting cleanup through subsequent push admission.
Fixes: #66739
Refs: #67113