Repository navigation
Conversation
Following #1067 we should be explicitly returning a 500 when we exhaust R2 retries now Fixes #1069 Signed-off-by: flakey5 <[email protected]>
ovflowd
reviewed
Oct 25, 2026
| if (err instanceof Error) { | ||
| // Error object likely from R2, let's handle it here | ||
|
|
||
| if (err.message.includes('10020')) { |
Member
There was a problem hiding this comment.
Should these error codes be in a constant with @ref to the r2 documentation (if these errors are even documented)
ovflowd
reviewed
Oct 25, 2026
| * @returns <T> if fn didn't throw, a {@link Reponse} otherwise | ||
| * @throws anything that's thrown by fn and isn't an error | ||
| */ | ||
| async function wrapR2Call<T>(fn: () => Promise<T>): Promise<T | Response> { |
Member
There was a problem hiding this comment.
Could the method name be maybe more descriptive?
Member
There was a problem hiding this comment.
Also could the type not be a generic T, maybe extend something that is an actual R2 call/method signature?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #1067 we should be explicitly returning a 500 when we exhaust R2 retries now
Fixes #1069