Skip to content

i18n(service-storage): ship the file and upload-session objects in all eleven platform languages - #30649

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-o3y7uf
Nov 5, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-o3y7uf

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Bill · project thread

domain:server#2 · os-bill · session_01Utp6Cai5CRdAs4u9gTipWU

Refs #30512 — package 10 of 11 (@objectstack/service-storage), moved ahead in the order by the seat now that #30335's storage half (#30627) has merged. The card stays open: the last PR of the series flips the bundle check to the platform locale table.

Clause-②: no
Metadata-protocol: none

维护者速读

  • 改了什么: 文件与上传会话两个对象(sys_file、sys_upload_session)的名称、字段、选项、帮助和视图名补上 7 种语言:繁中、阿语、法语、巴葡、俄语、德语、韩语,与平台语言表的 11 种一致。
  • 为什么改: 平台语言表(Platform locale table (ruling F of #29349): one list of 11 languages in spec, complete on every surface #29428 裁决 F)要求每个界面带齐 11 种语言;这是第 3 期按包补齐的第 10 个包(68 条),按席位安排插队。
  • 风险与回滚: 只加翻译数据和注册行,不动逻辑、schema、接口;原有 4 种一字未改;已包含 fix(service-storage): Setup storage Test connection answers in the caller's language (#30335) #30627 合入后的全部键。回滚即撤 PR。
  • 先看: src/translations/index.ts(按表标签注册,zh-CN 在 zh-Hant 前),再抽看 ar.objects.generated.ts。
  • 两分钟验证: node scripts/check-i18n-bundles.mjs --filter=storage 输出 in sync;node scripts/check-i18n-stale-fill.mjs 退出 0。
  • 需要你做的: 无,席位落地。

What changes

  • Seven new locales for the storage objects under the platform locale table's tags (zh-Hant, ar, fr, pt-BR, ru, de, ko): each a TAG.objects.generated.ts with all 68 leaves plus its TAG.source-hashes.generated.ts, written by the repo's own os i18n extract --fill=default --source-hashes, served through withSourceFallback like the existing three. zh-CN stays ahead of zh-Hant in index.ts.
  • The extract command in scripts/i18n-extract.config.ts lists the seven tags and its merge baseline imports the seven bundles, so check:i18n covers them from this PR on.

Acceptance notes

Verification

Package suite, typecheck, build (verify lock)
turbo build --filter=@objectstack/service-storage...: 17 tasks successful, exit 0
pnpm --filter @objectstack/service-storage test && typecheck
 Test Files  73 passed (73)
      Tests  1353 passed (1353)
os-verify-lock: VERDICT command-exit 0
i18n gates and size
node scripts/check-i18n-bundles.mjs --filter=storage       in sync                                  EXIT 0
node scripts/check-i18n-stale-fill.mjs                     OK (no new stale fills, 1 baselined)     EXIT 0
eslint --no-inline-config on the changed .ts files: exit 0
changed lines 1483 (+1482 / -1), 17 files: under the 3000-line threshold

Derived gate families (dispatch-gates --commands, reconciled with --ran): 56 run, 0 not measured, all exit 0; recorded in the os-dev-report on #30512.

Dogfood: not run — content-only package PR, no ! in the title and no (narrowing) arm.


🤖 Generated with Claude Code

https://claude.ai/code/session_01Utp6Cai5CRdAs4u9gTipWU

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/service-storage, touching 17 documentable anchor(s).

11 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/api/plugin-endpoints.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/automation/approvals.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/automation/flows.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/data-modeling/field-types.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/deployment/cli.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/kernel/contracts/storage-service.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/permissions/attachments-access.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects), sys_upload_session (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/permissions/system-context.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/protocol/objectql/types.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/ui/actions.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/ui/translations.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects), sys_upload_session (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))

⛔ 9 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/implementation-status.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/releases/index.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/releases/v15.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects), sys_upload_session (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/releases/v16.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects), sys_upload_session (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/releases/v17/17-0.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/releases/v17/17-5.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/releases/v17/index.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/releases/v18/18-2.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))
  • content/docs/releases/v18/18-3.mdx (via sys_file (symbol, a field of const object arObjects; a field of const object deObjects; a field of const object frObjects; a field of const object koObjects; a field of const object ptBRObjects; a field of const object ruObjects; a field of const object zhHantObjects))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • the SDK route bridge reached 63 of 221 client-bound route-ledger rows — the other 158 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 158: 0 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 55 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 103 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.
  • a key NAME is not a key, so the hand re-read the line above prescribes can land on the wrong schema. The same spelling is authorable on one governed type and a [REMOVED] tombstone on another for each of active, aria, joins, objects, template, tools and version (censused on [finding] tools is a key on BOTH AgentSchema (tombstoned, dead) and SkillSchema (live, cloud-attested), so a name-based search attributes skill examples to the agent key — it produced a false stop-the-line alarm on PR #19059 #19093 over the liveness ledger's governed types, top-level keys); nothing in a search result distinguishes the two, so a grep hit on a LIVE example reads as evidence about the DEAD key. Measured on fix(spec): the agent.tools liveness row says dead — it claimed live on a key the schema tombstoned #19059: content/docs/ai/agents.mdx was reported as contradicting the agent.tools tombstone over its tools: example at :161, which is inside the defineSkill({ block opened at :155 — the page was already correct. Settle ownership by PARSING the value against both schemas, never by the name: that literal PASSES SkillSchema, and as an AgentSchema it FAILS at tools with the tombstone prescription. ⛔ These names are not the whole class — a key retired through a .strict() guidance map leaves no tombstone in the walked shape and none of them here (tool.category, live as AIToolDefinition.category).

Coarse fallback — 10 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json ca37605c56a99f0dabbffd3278c1c59d207151bb → packageMentionDocs.

Which tree this was computed on

This run read content/docs from f0e70138dc38e71af8f2489318d7fa7b376aadc0 — the merge of head ef93f040b0a99eeae8c3dcc3dc03785d08c01821 into base ca37605c56a99f0dabbffd3278c1c59d207151bb, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin f0e70138dc38e71af8f2489318d7fa7b376aadc0 && git checkout f0e70138dc38e71af8f2489318d7fa7b376aadc0
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin ca37605c56a99f0dabbffd3278c1c59d207151bb ef93f040b0a99eeae8c3dcc3dc03785d08c01821 && git checkout -B drift-repro ca37605c56a99f0dabbffd3278c1c59d207151bb && git merge --no-ff ef93f040b0a99eeae8c3dcc3dc03785d08c01821

node scripts/docs-audit/affected-docs.mjs --json ca37605c56a99f0dabbffd3278c1c59d207151bb

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs ca37605c56a99f0dabbffd3278c1c59d207151bb → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actions github-actions Bot added documentation Improvements or additions to documentation tooling Fix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface labels Nov 5, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:server#2 · os-bill · session_01Utp6Cbvcmv8YWFhFJwzjKL

维护者速读

席位核对 — ACCEPT · domain:server#2 · head ef93f040b0a99eeae8c3dcc3dc03785d08c01821

  • 形态: draft, author objectstack-fleet[bot] (relay pr_create), no assignee, no review request; 17 files, +1482 −1; check-governed-merges --pr 30649: NOT governed, 1483 lines ≤ 3000. Title has no !. Refs #30512 (the card stays open).
  • Review face: TIER_DEFAULT (Clause-②: no: translated content for locales the platform table already declares, plus registration lines), written here by the seat.
  • Seat rulings held: table tags for the new files; existing zh-CN / ja-JP / es-ES untouched; zh-CN ahead of zh-Hant; no stale-fill baseline entry; serial after fix(service-storage): Setup storage Test connection answers in the caller's language (#30335) #30627 (merged fabd2595), branch at main ca37605c.
  • Seat read: index.ts registers the seven bundles through withSourceFallback with their source hashes (objects only; this package has no messages); scripts/i18n-extract.config.ts lists the seven tags, so the existing check:i18n covers them. Spot check ko: consistent with the existing three.
  • Dev readings (ef93f040): package tests 1353/1353 (73 files), typecheck, check-i18n-bundles --filter=storage in sync, check-i18n-stale-fill exit 0; derived gates 56, all exit 0, 0 NOT MEASURED. Content-only package PR: full dogfood owed on the last PR of the series, per the order. os-dev-report 6668777255.
  • 门禁 check-runs: in progress at ACCEPT; the seat queues once every check is green or an expected skip.
  • 落地条款: Refs i18n phase 3 (platform metadata and built-in emails): extraction and bundle checks read PLATFORM_LOCALES; backfill the seven missing locales #30512. Ordinary queue landing by this seat: pr_ready + automerge_enable on this head; the card ticks service-storage when it merges.

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review November 5, 2026 21:05
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Nov 5, 2026
Merged via the queue into main with commit 66a8822 Nov 5, 2026
49 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/project-thread-o3y7uf branch November 5, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/xl tooling Fix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant