Repository navigation
fix(example-showcase): the showcase_account extension declares the plural with its renamed label - #30738
Merged
objectstack-fleet[bot] merged 1 commit intoNov 6, 2026
Conversation
…ural with its renamed label An extension that renames an object without a pluralLabel is served with no plural, so the showcase list title fell back to the singular. Declare 'Accounts (Success Overlay)' beside 'Account (Success Overlay)' and pin that both translated /meta/object reads serve the pair in en and zh-CN. Fixes #30465 Co-authored-by: Claude <[email protected]> Claude-Session: https://claude.ai/code/session_016WV4cytQjG9X1CrCgytUM5
Contributor
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
Contributor
Author
|
domain:server#3 · os-elon-musk · session_016WV4cytQjG9X1CrCgytUM5 ACCEPT · #30465 · 2026-11-06T00:15Z · Head-sha: 席位核对
|
objectstack-fleet
Bot
deleted the
claude/issue-30465-showcase-plural-label
branch
November 6, 2026 00:49
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Elon · project thread
Fixes #30465
Clause-②: no
Metadata-protocol: none
Skills-docs: none — showcase example only
维护者速读
showcase_account对象扩展在改名Account (Success Overlay)的同时补上复数Accounts (Success Overlay)。examples/app-showcase/src/data/extensions/account.extension.ts,再看 dogfood 文件里新增的[#30465]用例。pnpm --filter @objectstack/dogfood exec vitest run test/showcase-object-extension-scalar-divergence.dogfood.test.ts,预期 8 条全绿。What changes
examples/app-showcase/src/data/extensions/account.extension.ts: the extension that renamesshowcase_accounttoAccount (Success Overlay)now declarespluralLabel: 'Accounts (Success Overlay)'. Since PR fix(objectql,rest)!: serve an object an extension renames without the base's plural (#30391) #30459 a rename without a plural is served with no plural, and the Console titles a list by the served plural, else the label; so the list title had fallen back to the singular.packages/qa/dogfood/test/showcase-object-extension-scalar-divergence.dogfood.test.ts(the file that already pins this object's served label): one new case. The extension declares the plural, andGET /meta/object/showcase_accountandGET /meta/objectboth serve the label and the plural as declared, inenand inzh-CN.examples/app-showcase/src/system/translations/**only if one is wanted. That bundle is the showcase's code catalog, not a.custompair.translateObjectreads a scalar that diverges from the packaged base only from the pair's catalog (The i18n catalog is resolved ahead of the document, so a tenant's own Studio rename never reaches either/meta/objectread — and neither do extension scalar overrides #8284 comparison rule, ADR-0146 D2). So a zh-CN entry there would not be served for either string. In zh-CN the singular is served as written (Account (Success Overlay)), and the plural now matches it. The pin measures exactly that.Acceptance notes
Fixes #30465line. The dev contract keeps card relations to the PR body only. An amend plus a lease-guarded force-push of this unshared branch was refused by the session's permission classifier, so the line stays. It closes the same card this body closes.Verification
Pin, reverse leg, typecheck, derived gates — head 32c6f57
pnpm --filter '@objectstack/dogfood^...' buildunderos-verify-lock.sh:VERDICT command-exit 0.pnpm --filter @objectstack/dogfood exec vitest run --maxWorkers=2 test/showcase-object-extension-scalar-divergence.dogfood.test.ts:VERDICT command-exit 0, Test Files 1 passed, Tests 8 passed (8).origin/main(git restore --source=origin/main; the showcase resolves from source, so no rebuild): the new case fails (exit 1, 1 failed), and the other 7 pass. Restored withgit checkout HEAD --; blob equals HEAD andgit diff HEADis empty.pnpm --filter @objectstack/example-showcase --filter @objectstack/dogfood typecheck: both rantsc --noEmit,VERDICT command-exit 0.node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackat 32c6f57: 55 commands, each run with its exit code captured before any pipe. 53 exit 0 on the first pass.check-plugin-teardown-shape --self-testexit 3 (its pinned fixture commit was outside the shallow clone), then exit 0 after fetching that commit.pnpm check:dual-build-cjs-loadsexit 3, NOT MEASURED: it needs a whole-workspace build, and only the dogfood closure was built. CI runs it.dispatch-gates --ran: 55 derived, 54 run, 1 NOT-MEASURED, 0 UNRUN, exit 0.@objectstack/example-showcaseand@objectstack/dogfoodare bothprivate: true, soskip-changeset.!andClause-②has no narrowing arm.Generated by Claude Code
🤖 Generated with Claude Code