Repository navigation
fix: missing content in the pdf output for encrypted files - #181
Merged
Merged
Conversation
In pypdf v7, the merged content streams are now serialized before encryption. So the overlay is no longer saved as an empty stream. This causes the output credentials to be just a copy of empty template without the actual name, course or verification URL.
Agrendalath
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In pypdf v7, the merged content streams are now serialized before encryption. So the overlay is no longer saved as an empty stream. This causes the output credentials to be just a copy of empty template without the actual name, course or verification URL.
Testing instructions
tutor mounts add lms:/path/to-learning-credentials:/mnt/learning-credentialsandtutor dev start -dtutor dev exec lms pip install -e /mnt/learning-credentialsandtutor dev exec python manage.py lms migrate(be on the main branch)blank.pdffrom the attachments with the NameBlankand slugblanklearning_credentials.processors.retrieve_completionslearning_credentials.generates.generate_pdf_credentialPDF test credential.Merge checklist:
Check off if complete or not applicable:
Testing assets