Repository navigation
remove discontinued bmw module - #3181
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the discontinued BMW “bimmer_connected” SoC vehicle module from the codebase and adds a datastore migration to disable existing bmwbc configurations during upgrade.
Changes:
- Dropped
bimmer_connectedfromrequirements.txt. - Removed the
packages/modules/vehicles/bmwbc/implementation (api.py,config.py,soc.py). - Bumped datastore version and added an upgrade step to replace
bmwbcvehicle SoC configs withNO_MODULE, plus a user-facing info message.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| requirements.txt | Removes the bimmer_connected dependency pin. |
| packages/modules/vehicles/bmwbc/api.py | Deletes the BMW bimmer_connected API integration. |
| packages/modules/vehicles/bmwbc/config.py | Deletes the BMWbc configuration classes. |
| packages/modules/vehicles/bmwbc/soc.py | Deletes the BMWbc SoC module entrypoint/vehicle wrapper. |
| packages/helpermodules/update_config.py | Increments datastore version and migrates bmwbc configs to NO_MODULE, attempts package uninstall, and posts an info message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix typo an new line.
benderl
approved these changes
Mar 5, 2026
Contributor
|
Im UI sollten die Dateien des Moduls ebenfalls entfernt werden. |
benderl
requested changes
Mar 5, 2026
benderl
left a comment
benderl
left a comment
Contributor
There was a problem hiding this comment.
Wiki Dateien unter docs noch entfernen.
Contributor
Author
|
Das Wiki wird in einem separaten PR aufgeräumt: #3186 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.