Skip to content

fix failed phase switches, manual lock init #3235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 2 commits into from
Mar 24, 2026
Merged

fix failed phase switches, manual lock init #3235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d22775b
fix failed phase switches, manual lock init
LKuemmel Mar 24, 2026
9d86727
review
LKuemmel Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/control/chargepoint/chargepoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,10 @@ def _is_phase_switch_required(self) -> bool:
STOP_CHARGING = ", dafür wird die Ladung unterbrochen."

def check_phase_switch_completed(self):
def _set_failed_phase_switches() -> None:
# Umschaltung fehlgeschlagen
if self.data.set.phases_to_use != self.data.get.phases_in_use:
self.data.control_parameter.failed_phase_switches += 1
Comment thread
LKuemmel marked this conversation as resolved.
Resolved
try:
evu_counter = data.data.counter_all_data.get_evu_counter()
charging_ev = self.data.set.charging_ev_data
Expand Down Expand Up @@ -369,8 +373,10 @@ def check_phase_switch_completed(self):
if phase_switch.phase_switch_thread_alive(self.num) is False:
self.data.control_parameter.state = ChargepointState.PHASE_SWITCH_AWAITED
if self._is_phase_switch_required() is False:
_set_failed_phase_switches()
self.data.control_parameter.state = ChargepointState.CHARGING_ALLOWED
else:
_set_failed_phase_switches()
self.data.control_parameter.state = ChargepointState.CHARGING_ALLOWED
except Exception:
log.exception("Fehler in der Ladepunkt-Klasse von "+str(self.num))
Expand All @@ -396,7 +402,6 @@ def _set_failed_phase_switches() -> None:
self.data.set.phases_to_use = self.data.control_parameter.phases
if self.hw_supports_phase_switch():
if self._is_phase_switch_required():
_set_failed_phase_switches()
# Wenn die Umschaltverzögerung aktiv ist, darf nicht umgeschaltet werden.
if (self.data.control_parameter.state != ChargepointState.PERFORMING_PHASE_SWITCH and
(self.data.control_parameter.state != ChargepointState.WAIT_FOR_USING_PHASES or
Expand Down
1 change: 1 addition & 0 deletions packages/helpermodules/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ def setup_added_chargepoint():
charge_template = SubData.ev_charge_template_data[f"ct{SubData.ev_data['ev0'].data.charge_template}"]
charge_template = dataclass_utils.asdict(charge_template.data)
Pub().pub(f'openWB/chargepoint/{new_id}/set/charge_template', charge_template)
Pub().pub(f'openWB/chargepoint/{new_id}/set/manual_lock', False)
self.max_id_hierarchy = self.max_id_hierarchy + 1
Pub().pub("openWB/set/command/max_id/hierarchy", self.max_id_hierarchy)
if self.max_id_chargepoint_template == -1:
Expand Down
Loading