Repository navigation
Add Renault odometer - #3254
Merged
Merged
Add Renault odometer#3254
Conversation
Removed validation checks for response structure and error handling.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds odometer support to the Renault vehicle integration by retrieving cockpit data from the Kamereon API and returning it via CarState.
Changes:
- Fetch Renault “cockpit” endpoint data in addition to battery status.
- Map
cockpit.data.attributes.totalMileageintoCarState.odometer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+84
to
+98
| # Step 9 - cockpit data for odometer/totalMileage | ||
| data = urllib.parse.urlencode(country_data) | ||
| data = data.encode('Big5') | ||
| reg = urllib.request.Request(KAMEREON_ROOTURL + '/commerce/v1/accounts/' + | ||
| kamereonaccountid + '/kamereon/kca/car-adapter/v1/cars/' | ||
| + vin + '/cockpit?' + data.decode("utf-8")) | ||
| reg.add_header('x-gigya-id_token', gigya_jwttoken) | ||
| reg.add_header('apikey', KAMEREON_API_KEY) | ||
| response = urllib.request.urlopen(reg) | ||
| responsetext = response.read() | ||
| cockpit = json.loads(responsetext) | ||
|
|
||
| return CarState(soc=float(batt['data']['attributes']['batteryLevel']), | ||
| range=float(batt['data']['attributes']['batteryAutonomy'])) | ||
| range=float(batt['data']['attributes']['batteryAutonomy']), | ||
| odometer=float(cockpit['data']['attributes']['totalMileage'])) |
There was a problem hiding this comment.
The new cockpit request makes fetch_soc fail entirely if the cockpit endpoint is unavailable or returns an unexpected payload (e.g., missing data.attributes.totalMileage). Consider handling errors for this optional field (e.g., catch network/JSON/key errors and set odometer=None) so SOC/range can still be returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getestet mit Renault Megane E-Tech