Repository navigation
octopus energy: fix timezone handling - #3268
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes timezone handling for Octopus Energy (Germany) flexible tariff price calculation by explicitly converting between UTC and Europe/Berlin, and adds regression tests to validate correct behavior across DST (summer/winter time).
Changes:
- Introduce explicit
Europe/Berlintimezone conversion when matching time-of-use slots and generating hourly epoch keys. - Correct time-of-use slot selection logic for midnight wrap-around.
- Add pytest coverage for expected price timestamps/values in both summer and winter time scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
packages/modules/electricity_pricing/flexible_tariffs/octopusenergy/tariff.py |
Uses an explicit German timezone for slot matching and timestamps; improves midnight wrap handling. |
packages/modules/electricity_pricing/flexible_tariffs/octopusenergy/tariff_test.py |
Adds DST-focused tests by freezing datetime.now() and asserting the produced hourly price map. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket #66002546