Repository navigation
power limit is int, format bat power limit str - #3276
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts battery power-limit typing and user-facing status text to align with the set_power_limit interface expecting integer watt values (context: #3275).
Changes:
- Change
Bat.Set.power_limittype hint fromfloattoint. - Cast computed per-battery
power_limittointbefore publishing/dispatching. - Format battery
state_strmessages using kW with rounding for charge/discharge.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/control/bat.py |
Updates per-battery set/power_limit type hint to integer. |
packages/control/bat_all.py |
Ensures distributed power_limit values are integers and improves state_str formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
42
to
45
| @dataclass | ||
| class Set: | ||
| power_limit: float = field(default=None, metadata={"topic": "set/power_limit"}) | ||
| power_limit: int = field(default=None, metadata={"topic": "set/power_limit"}) | ||
|
|
There was a problem hiding this comment.
power_limit is annotated as int but the field default is None, so the type should be Optional[int] (and import Optional) to match actual runtime values and the AbstractBat.set_power_limit(self, power_limit: Optional[int]) contract.
LKuemmel
added a commit
that referenced
this pull request
Apr 10, 2026
* power limit is int, format bat power limit str * type hint --------- Co-authored-by: benderl <[email protected]>
ndrsnhs
pushed a commit
to ndrsnhs/core
that referenced
this pull request
Aug 24, 2026
* power limit is int, format bat power limit str * type hint --------- Co-authored-by: benderl <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_power_limit erwartet im Type Hint ein int.
Kommentar zu #3275
Formatierung: https://forum.openwb.de/viewtopic.php?p=141878#p141878