Skip to content

Remove charge limit from settings dialog #3286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benderl merged 1 commit into from
Apr 13, 2026
Merged

Remove charge limit from settings dialog #3286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 0 additions & 63 deletions packages/modules/web_themes/koala/source/src/components/ChargePointEcoSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,40 +39,6 @@
</q-btn-group>
</div>
</div>

<div class="text-subtitle2 q-mt-sm q-mr-sm">Begrenzung</div>
<div class="row items-center justify-center q-ma-none q-pa-none no-wrap">
<q-btn-group class="col">
<q-btn
v-for="mode in limitModes"
:key="mode.value"
:color="limitMode.value === mode.value ? 'primary' : 'grey'"
:label="mode.label"
size="sm"
class="col"
@click="limitMode.value = mode.value"
/>
</q-btn-group>
</div>
<SliderStandard
v-if="limitMode.value === 'soc'"
title="SoC-Limit für das Fahrzeug"
:min="5"
:max="100"
:step="5"
unit="%"
v-model="limitSoC.value"
class="q-mt-md"
/>
<SliderStandard
v-if="limitMode.value === 'amount'"
title="Energie-Limit"
:min="1"
:max="50"
unit="kWh"
v-model="limitEnergy.value"
class="q-mt-md"
/>
<div v-if="etConfigured">
<div class="text-subtitle2 q-my-sm">
Preisgrenze für strompreisbasiertes Laden
Expand Down Expand Up @@ -166,21 +132,6 @@ const props = defineProps<{

const mqttStore = useMqttStore();

const limitModes = computed(() => {
let modes = [
{ value: 'none', label: 'keine', color: 'primary' },
{ value: 'soc', label: 'EV-SoC', color: 'primary' },
{ value: 'amount', label: 'Energie', color: 'primary' },
];
if (vehicleSocType.value === undefined) {
modes = modes.filter((mode) => mode.value !== 'soc');
}
return modes;
});

const vehicleSocType = computed(() =>
mqttStore.chargePointConnectedVehicleSocType(props.chargePointId),
)?.value;

const phaseOptions = [
{ value: 1, label: '1' },
Expand Down Expand Up @@ -208,20 +159,6 @@ const numPhases = computed(() =>
mqttStore.chargePointConnectedVehicleEcoChargePhases(props.chargePointId),
);

const limitMode = computed(() =>
mqttStore.chargePointConnectedVehicleEcoChargeLimit(props.chargePointId),
);

const limitSoC = computed(() =>
mqttStore.chargePointConnectedVehicleEcoChargeLimitSoC(props.chargePointId),
);

const limitEnergy = computed(() =>
mqttStore.chargePointConnectedVehicleEcoChargeLimitEnergy(
props.chargePointId,
),
);

const etConfigured = computed(() => mqttStore.etProviderConfigured);

const maxPrice = computed(() =>
Expand Down
65 changes: 0 additions & 65 deletions packages/modules/web_themes/koala/source/src/components/ChargePointInstantSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,39 +34,6 @@
</q-btn-group>
</div>
</div>
<div class="text-subtitle2 q-mt-sm q-mr-sm">Begrenzung</div>
<div class="row items-center justify-center q-ma-none q-pa-none no-wrap">
<q-btn-group class="col">
<q-btn
v-for="mode in limitModes"
:key="mode.value"
:color="limitMode.value === mode.value ? 'primary' : 'grey'"
:label="mode.label"
size="sm"
class="col"
@click="limitMode.value = mode.value"
/>
</q-btn-group>
</div>
<SliderStandard
v-if="limitMode.value === 'soc'"
title="SoC-Limit für das Fahrzeug"
:min="5"
:max="100"
:step="5"
unit="%"
v-model="limitSoC.value"
class="q-mt-md"
/>
<SliderStandard
v-if="limitMode.value === 'amount'"
title="Energie-Limit"
:min="1"
:max="50"
unit="kWh"
v-model="limitEnergy.value"
class="q-mt-md"
/>
</template>

<script setup lang="ts">
Expand All @@ -80,22 +47,6 @@ const props = defineProps<{

const mqttStore = useMqttStore();

const limitModes = computed(() => {
let modes = [
{ value: 'none', label: 'keine', color: 'primary' },
{ value: 'soc', label: 'EV-SoC', color: 'primary' },
{ value: 'amount', label: 'Energie', color: 'primary' },
];
if (vehicleSocType.value === undefined) {
modes = modes.filter((mode) => mode.value !== 'soc');
}
return modes;
});

const vehicleSocType = computed(() =>
mqttStore.chargePointConnectedVehicleSocType(props.chargePointId),
)?.value;

const phaseOptions = [
{ value: 1, label: '1' },
{ value: 3, label: 'Maximum' },
Expand Down Expand Up @@ -124,22 +75,6 @@ const instantChargeCurrentDc = computed(() => {
const numPhases = computed(() =>
mqttStore.chargePointConnectedVehicleInstantChargePhases(props.chargePointId),
);

const limitMode = computed(() =>
mqttStore.chargePointConnectedVehicleInstantChargeLimit(props.chargePointId),
);

const limitSoC = computed(() =>
mqttStore.chargePointConnectedVehicleInstantChargeLimitSoC(
props.chargePointId,
),
);

const limitEnergy = computed(() =>
mqttStore.chargePointConnectedVehicleInstantChargeLimitEnergy(
props.chargePointId,
),
);
</script>

<style scoped>
Expand Down
58 changes: 0 additions & 58 deletions packages/modules/web_themes/koala/source/src/components/ChargePointPvSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,40 +39,6 @@
</q-btn-group>
</div>
</div>

<div class="text-subtitle2 q-mt-sm q-mr-sm">Begrenzung</div>
<div class="row items-center justify-center q-ma-none q-pa-none no-wrap">
<q-btn-group class="col">
<q-btn
v-for="mode in limitModes"
:key="mode.value"
:color="limitMode.value === mode.value ? 'primary' : 'grey'"
:label="mode.label"
size="sm"
class="col"
@click="limitMode.value = mode.value"
/>
</q-btn-group>
</div>
<SliderStandard
v-if="limitMode.value === 'soc'"
title="SoC-Limit für das Fahrzeug"
:min="5"
:max="100"
:step="5"
unit="%"
v-model="limitSoC.value"
class="q-mt-md"
/>
<SliderStandard
v-if="limitMode.value === 'amount'"
title="Energie-Limit"
:min="1"
:max="50"
unit="kWh"
v-model="limitEnergy.value"
class="q-mt-md"
/>
<div v-if="vehicleSocType !== undefined">
<SliderStandard
title="Mindest-SoC für das Fahrzeug"
Expand Down Expand Up @@ -146,18 +112,6 @@ const props = defineProps<{

const mqttStore = useMqttStore();

const limitModes = computed(() => {
let modes = [
{ value: 'none', label: 'keine', color: 'primary' },
{ value: 'soc', label: 'EV-SoC', color: 'primary' },
{ value: 'amount', label: 'Energie', color: 'primary' },
];
if (vehicleSocType.value === undefined) {
modes = modes.filter((mode) => mode.value !== 'soc');
}
return modes;
});

const vehicleSocType = computed(() =>
mqttStore.chargePointConnectedVehicleSocType(props.chargePointId),
)?.value;
Expand Down Expand Up @@ -213,18 +167,6 @@ const pvMinSocCurrent = computed(() =>
),
);

const limitMode = computed(() =>
mqttStore.chargePointConnectedVehiclePvChargeLimit(props.chargePointId),
);

const limitSoC = computed(() =>
mqttStore.chargePointConnectedVehiclePvChargeLimitSoC(props.chargePointId),
);

const limitEnergy = computed(() =>
mqttStore.chargePointConnectedVehiclePvChargeLimitEnergy(props.chargePointId),
);

const feedInLimit = computed(() =>
mqttStore.chargePointConnectedVehiclePvChargeFeedInLimit(props.chargePointId),
);
Expand Down
Loading