Skip to content

Qcells active battery control - some fixes #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 3 commits into from
Apr 22, 2026
Merged

Qcells active battery control - some fixes #3314

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0773955
adding active battery control for qcells and new field for overload s…
Xoffroad Mar 25, 2026
c2ccbe5
remove field for max_power and use max_charge_power and max_discharge…
Xoffroad Mar 26, 2026
24e2d0f
fix: stabilize QCells active battery control in mode 1
Xoffroad Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 29 additions & 4 deletions packages/modules/devices/qcells/qcells/bat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@
REMOTE_CONTROL_MODE_REG = 0x7C # U16: 0=Disabled, 1=Enabled Power Control
REMOTE_CONTROL_SET_TYPE_REG = 0x7D # U16: 1=Set
REMOTE_CONTROL_ACTIVE_POWER_REG = 0x7E # S32: Active Power Sollwert in Watt
REMOTE_CONTROL_REACTIVE_POWER_REG = 0x80 # S32: Reactive Power Sollwert (0)
REMOTE_CONTROL_DURATION_REG = 0x82 # U16: Dauer in Sekunden
REMOTE_CONTROL_TARGET_SOC_REG = 0x83 # U16: Target SoC (Dummy 0)
REMOTE_CONTROL_TARGET_ENERGY_REG = 0x84 # U32: Target Energy (Dummy 0)
REMOTE_CONTROL_TARGET_POWER_REG = 0x86 # S32: Target Charge/Discharge Power (Dummy 0)
REMOTE_CONTROL_TIMEOUT_REG = 0x88 # U16: Timeout in Sekunden

MODE_1_DISABLED = 0
Expand Down Expand Up @@ -97,27 +101,36 @@ def _get_active_power_target(self, power_limit: int) -> int:
cp_power = int(data.data.cp_all_data.data.get.power)
house_load = max(0, home_consumption + cp_power)
pv_generation = max(0, int(data.data.pv_all_data.data.get.power * -1))
ap_target = power_limit + house_load - pv_generation
# Mode 1 / Enabled Battery Control: house_load wird inverter-intern bereits berücksichtigt.
ap_target = power_limit - pv_generation

try:
evu_counter = data.data.counter_all_data.get_evu_counter()
import_limit = int(evu_counter.data.config.max_total_power)
except Exception:
import_limit = 0

if import_limit > 0:
ap_target = min(ap_target, import_limit)
import_bound = None
if import_limit > 0 and ap_target > 0:
import_bound = import_limit - house_load
ap_target = min(ap_target, import_bound)

log.debug((
f"QCells Mode1 target: power_limit={power_limit}W, home_consumption={home_consumption}W, "
f"cp_power={cp_power}W, house_load={house_load}W, "
f"pv_generation={pv_generation}W, import_limit={import_limit}W -> ap_target={ap_target}W"
f"pv_generation={pv_generation}W, import_limit={import_limit}W, "
f"import_bound={import_bound}W -> ap_target={ap_target}W"
))
return int(ap_target)

def _write_mode1(self, ap_target: int, unit: int) -> None:
"""Schreibt die Mode 1 Remote Control Register (0x7C-0x88)."""
duration, timeout = self._get_mode1_timing()
log.debug((
f"QCells Mode1 write: mode={MODE_1_ENABLED_POWER_CONTROL}, set_type={SET_TYPE_SET}, "
f"active_power={ap_target}W, reactive_power=0var, duration={duration}s, "
f"target_soc=0, target_energy=0Wh, target_power=0W, timeout={timeout}s"
))
with self.client:
self.client.write_register(
REMOTE_CONTROL_MODE_REG, MODE_1_ENABLED_POWER_CONTROL,
Expand All @@ -128,9 +141,21 @@ def _write_mode1(self, ap_target: int, unit: int) -> None:
self.client.write_register(
REMOTE_CONTROL_ACTIVE_POWER_REG, ap_target,
data_type=ModbusDataType.INT_32, wordorder=Endian.Little, unit=unit)
self.client.write_register(
REMOTE_CONTROL_REACTIVE_POWER_REG, 0,
data_type=ModbusDataType.INT_32, wordorder=Endian.Little, unit=unit)
self.client.write_register(
REMOTE_CONTROL_DURATION_REG, duration,
data_type=ModbusDataType.UINT_16, unit=unit)
self.client.write_register(
REMOTE_CONTROL_TARGET_SOC_REG, 0,
data_type=ModbusDataType.UINT_16, unit=unit)
self.client.write_register(
REMOTE_CONTROL_TARGET_ENERGY_REG, 0,
data_type=ModbusDataType.UINT_32, wordorder=Endian.Little, unit=unit)
self.client.write_register(
REMOTE_CONTROL_TARGET_POWER_REG, 0,
data_type=ModbusDataType.INT_32, wordorder=Endian.Little, unit=unit)
self.client.write_register(
REMOTE_CONTROL_TIMEOUT_REG, timeout,
data_type=ModbusDataType.UINT_16, unit=unit)
Expand Down
Loading